8355353: File Leak in os::read_image_release_file of os.cpp:1552

coleenp · coleenp · commit a8cd01f6e207 · 2025-05-05T11:57:01.000Z
Reviewed-by: zgu, jsjolen
diff --git a/src/hotspot/share/runtime/os.cpp b/src/hotspot/share/runtime/os.cpp
@@ -1551,6 +1551,7 @@ void os::read_image_release_file() {
   fseek(file, 0, SEEK_END);
   long sz = ftell(file);
   if (sz == -1) {
+    fclose(file);
     return;
   }
   fseek(file, 0, SEEK_SET);

Original file line number	Diff line number	Diff line change
`@@ -1551,6 +1551,7 @@ void os::read_image_release_file() {`
`1551`	`1551`	`fseek(file, 0, SEEK_END);`
`1552`	`1552`	`long sz = ftell(file);`
`1553`	`1553`	`if (sz == -1) {`
	`1554`	`+ fclose(file);`
`1554`	`1555`	`return;`
`1555`	`1556`	`}`
`1556`	`1557`	`fseek(file, 0, SEEK_SET);`