Skip to content

[Review Comment]: Precision regarding commit_valid only 1 cycle. #229

@Gchauvon

Description

@Gchauvon

Comment

The commit_valid signal will be 1 exactly one clk cycle. It is not required that a commit transaction is performed for
each offloaded instruction individually. Instructions can be signalled to be non-speculative or to be killed in batch.

Regarding this point of the specification:
Does it mean commit_valid can not be asserted for 2 clk cycles in a row if 2 issue transaction with different ids happens in a row ?

I believe it is a scenario that should be allowed especially for non-speculative CPU. Even though we can "commit" in batch, we should be able to not to do it and "commit" for each issue transaction.

Proposed Resolution

Precise that we can have a commit transaction for each issue transaction

Addition Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    public-reviewIssues during public review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions