Skip to content

Commit e4a3126

Browse files
committed
Fix #2 - Home is missing from server rendered breadcrumbs on luma
1 parent 40e24ad commit e4a3126

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

view/frontend/templates/hyva/product/breadcrumbs.phtml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,18 @@ use Opengento\ProductBreadcrumbs\ViewModel\Product\Breadcrumbs as BreadcrumbsCon
1616

1717
/** @var BreadcrumbsConfig $config */
1818
$config = $viewModels->require(BreadcrumbsConfig::class);
19+
$isClientSideRendered = !$config->isServerSideRendered() || $config->isClientSideOverrideAllowed();
1920
?>
20-
<div id="product_breadcrumbs" x-init="generateProductBreadcrumbsOnProductPage()">
21+
<div id="product_breadcrumbs"<?= $isClientSideRendered ? ' x-init="generateProductBreadcrumbsOnProductPage()"' : '' ?>>
2122
<?php if ($config->isServerSideRendered()): ?>
2223
<?= $block->fetchView($block->getTemplateFile('Magento_Theme::html/breadcrumbs.phtml')) ?>
2324
<?php endif; ?>
2425
</div>
25-
<script>
26-
function generateProductBreadcrumbsOnProductPage() {
27-
<?php if (!$config->isServerSideRendered() || $config->isClientSideOverrideAllowed()): ?>
28-
<?php $breadcrumbsTemplate = '<div id="product_breadcrumbs">' . $block->fetchView($block->getTemplateFile('Magento_Catalog::product/view/breadcrumbs.phtml')) . '</div>'; ?>
29-
hyva.replaceDomElement('#product_breadcrumbs', '<?= $escaper->escapeJs($breadcrumbsTemplate) ?>');
26+
<?php if ($isClientSideRendered): ?>
27+
<script>
28+
function generateProductBreadcrumbsOnProductPage() {
29+
<?php $breadcrumbsTemplate = '<div id="product_breadcrumbs">' . $block->fetchView($block->getTemplateFile('Magento_Catalog::product/view/breadcrumbs.phtml')) . '</div>'; ?>
30+
hyva.replaceDomElement('#product_breadcrumbs', '<?= $escaper->escapeJs($breadcrumbsTemplate) ?>');
31+
}
32+
</script>
3033
<?php endif; ?>
31-
}
32-
</script>

view/frontend/templates/product/breadcrumbs.phtml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@ $config = $block->getData('breadcrumbsConfig');
2424
$catalogHelper = $this->helper(CatalogHelper::class);
2525
/** @var BreadcrumbsBlock $breadcrumbs */
2626
$breadcrumbs = $block->getLayout()->createBlock(BreadcrumbsBlock::class);
27+
$breadcrumbs->addCrumb(
28+
'home',
29+
[
30+
'label' => __('Home'),
31+
'title' => __('Go to Home Page'),
32+
'link' => $block->getBaseUrl()
33+
]
34+
);
2735
foreach ($catalogHelper->getBreadcrumbPath() as $name => $crumb) {
2836
$breadcrumbs->addCrumb($name, $crumb);
2937
}

0 commit comments

Comments
 (0)