Skip to content

Commit 80d0072

Browse files
committed
Fix some typos
1 parent 2cdadf4 commit 80d0072

File tree

4 files changed

+21
-13
lines changed

4 files changed

+21
-13
lines changed

README.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
[![Packagist](https://img.shields.io/packagist/dt/opengento/module-product-breadcrumbs.svg?style=flat-square)](https://packagist.org/packages/opengento/module-product-breadcrumbs/stats)
66
[![Packagist](https://img.shields.io/packagist/dm/opengento/module-product-breadcrumbs.svg?style=flat-square)](https://packagist.org/packages/opengento/module-product-breadcrumbs/stats)
77

8-
This module allows to toggle server side rendered breadcrumb for product pages.
8+
This module allows to toggle server side rendered breadcrumbs for product pages.
99

1010
- [Setup](#setup)
1111
- [Composer installation](#composer-installation)
@@ -41,13 +41,16 @@ bin/magento setup:upgrade
4141

4242
## Features
4343

44-
This module is Hyva-ready!
45-
This module render server-sided product breadcrumb so it's visible to any robot without requiring any js loads and process.
46-
Can you still enable the js breadcrumb so your user can see natural breadcrumbs following their navigation.
44+
This module render server-sided product breadcrumbs so it's visible to any robot without requiring any js loads and process.
45+
Can you still enable the js breadcrumbs so your user can see natural breadcrumbs following their navigation.
46+
47+
If your store use Hyva theme, this module works out-of-the-box when the breadcrumbs is server-side rendering. If you want
48+
to print a default breadcrumb then override it with client-side rendering, you need to override the client-side rendered
49+
breadcrumbs template and update the script.
4750

4851
## Documentation
4952

50-
- Toggle render server side the product rbeadcrumbs
53+
- Toggle render server side the product breadcrumbs
5154
- Toggle allows client side to override product breadcrumbs based on navigation
5255
- Select best strategy to generate the product breadcrumbs (native, deepest, shallowest)
5356
- Exclude some root categories from being used to generate the breadcrumbs

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "opengento/module-product-breadcrumbs",
3-
"description": "This module allows to toggle server side rendered breadcrumb for product pages.",
3+
"description": "This module allows to toggle server side rendered breadcrumbs for product pages.",
44
"keywords": [
55
"php",
66
"magento",
@@ -15,10 +15,10 @@
1515
"require": {
1616
"php": "^8.1",
1717
"magento/framework": "*",
18-
"magento/module-backend": "*",
1918
"magento/module-config": "*",
2019
"magento/module-store": "*",
21-
"magento/module-catalog": "*"
20+
"magento/module-catalog": "*",
21+
"magento/module-theme": "*"
2222
},
2323
"require-dev": {
2424
"magento/magento-coding-standard": "^33",

etc/adminhtml/system.xml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,23 +10,28 @@
1010
<section id="catalog">
1111
<group id="seo">
1212
<field id="render_product_breadcrumbs_server_side" translate="label comment" type="select" sortOrder="30" showInDefault="1" canRestore="1">
13-
<label>Render Product Breadcrumbs from Server Side</label>
14-
<comment>This setting depends of the theme. For Hyva store, also use the hyva settings.</comment>
13+
<label>Render Product Breadcrumbs from Server-Side</label>
14+
<comment>This setting depends of the theme. If your store use Hyva theme, disable client-side breadcrumbs rendering.</comment>
1515
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
16+
<config_path>catalog/seo/render_product_breadcrumbs_server_side</config_path>
1617
</field>
1718
<field id="override_product_breadcrumbs_client_side" translate="label comment" type="select" sortOrder="31" showInDefault="1" canRestore="1">
18-
<label>Override Product Breadcrumbs on Client Side</label>
19-
<comment>This setting depends of the theme. For Hyva store, also use the hyva settings.</comment>
19+
<label>Override Product Breadcrumbs on Client-Side</label>
20+
<comment>If your store use Hyva theme, this setting is by-passed. You may want to enable the Hyva client-side breadcrumbs rendering.</comment>
2021
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
22+
<config_path>catalog/seo/override_product_breadcrumbs_client_side</config_path>
2123
</field>
2224
<field id="product_breadcrumbs_strategy" translate="label" type="select" sortOrder="32" showInDefault="1" canRestore="1">
2325
<label>Product Breadcrumbs Strategy</label>
2426
<source_model>Opengento\ProductBreadcrumbs\Model\Config\Source\Strategies</source_model>
27+
<config_path>catalog/seo/product_breadcrumbs_strategy</config_path>
2528
</field>
2629
<field id="product_breadcrumbs_exclude_categories" translate="label comment" type="multiselect" sortOrder="33" showInDefault="1" canRestore="1">
2730
<label>Product Breadcrumbs Excluded Categories</label>
2831
<source_model>Opengento\ProductBreadcrumbs\Model\Config\Source\TopLevelCategories</source_model>
32+
<can_be_empty>1</can_be_empty>
2933
<comment>Leave empty to allow all categories on breadcrumbs.</comment>
34+
<config_path>catalog/seo/product_breadcrumbs_exclude_categories</config_path>
3035
</field>
3136
</group>
3237
</section>

etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
99
<module name="Opengento_ProductBreadcrumbs">
1010
<sequence>
11-
<module name="Magento_Backend"/>
1211
<module name="Magento_Config"/>
1312
<module name="Magento_Store"/>
1413
<module name="Magento_Catalog"/>
1514
<module name="Magento_Theme"/>
15+
<module name="Hyva_Theme"/>
1616
</sequence>
1717
</module>
1818
</config>

0 commit comments

Comments
 (0)