Optimize condition & prevent exception on specific product types

Author: thomas-kl1

Plugin/Block/AbstractStockQtyPlugin.php

@@ -7,6 +7,7 @@
 
 namespace Opengento\InventoryStockQty\Plugin\Block;
 
+use Magento\Catalog\Model\Product;
 use Magento\CatalogInventory\Block\Stockqty\AbstractStockqty;
 use Magento\Framework\Exception\InputException;
 use Magento\Framework\Exception\LocalizedException;
@@ -37,16 +38,9 @@ public function __construct(
     public function aroundIsMsgVisible(AbstractStockqty $subject, callable $proceed): bool
     {
         $product = $subject->getProduct();
-        $sku = $product->getSku();
-        $stockId = (int)$this->stockByWebsiteId->execute((int)$product->getStore()->getWebsiteId())->getStockId();
-        $stockItemConfig = $this->getStockItemConfiguration->execute($sku, $stockId);
 
-        return $stockItemConfig->isManageStock()
-            && $this->isSourceItemManagementAllowedForProductType->execute($product->getTypeId())
-            && $this->isSalableQtyAvailableForDisplaying->execute(
-            $this->getProductSalableQty->execute($sku, $stockId),
-            $stockItemConfig
-        );
+        return $this->isSourceItemManagementAllowedForProductType->execute($product->getTypeId())
+            && $this->isSalableQtyAvailable($product);
     }
 
     /**
@@ -65,4 +59,21 @@ public function aroundGetStockQtyLeft(AbstractStockqty $subject, callable $proce
             )->getStockId()
         );
     }
+
+    /**
+     * @throws SkuIsNotAssignedToStockException
+     * @throws InputException
+     * @throws LocalizedException
+     */
+    private function isSalableQtyAvailable(Product $product): bool
+    {
+        $sku = $product->getSku();
+        $stockId = (int)$this->stockByWebsiteId->execute((int)$product->getStore()->getWebsiteId())->getStockId();
+        $stockItemConfig = $this->getStockItemConfiguration->execute($sku, $stockId);
+
+        return $stockItemConfig->isManageStock() && $this->isSalableQtyAvailableForDisplaying->execute(
+            $this->getProductSalableQty->execute($sku, $stockId),
+            $stockItemConfig
+        );
+    }
 }