phpcs

Author: thomas-kl1

Block/Adminhtml/Action/Edit/BackButton.php

@@ -30,7 +30,7 @@ public function getButtonData(): array
             'label' => new Phrase('Back'),
             'on_click' => 'location.href = "' . $this->urlBuilder->getUrl('*/*/') . '";',
             'class' => 'back',
-            'sort_order' => 10
+            'sort_order' => 10,
         ];
     }
 }

Block/Adminhtml/Action/Edit/ResetButton.php

@@ -18,7 +18,7 @@ public function getButtonData(): array
             'label' => new Phrase('Reset'),
             'class' => 'reset',
             'on_click' => 'location.reload();',
-            'sort_order' => 20
+            'sort_order' => 20,
         ];
     }
 }

Model/Action/Erase/CancelAction.php

@@ -48,7 +48,7 @@ public function execute(ActionContextInterface $actionContext): ActionResultInte
         return $this->createActionResult(
             [
                 ArgumentReader::ERASE_ENTITY => $this->resolveEntity(...$arguments),
-                'canceled' => $this->eraseManagement->cancel(...$arguments)
+                'canceled' => $this->eraseManagement->cancel(...$arguments),
             ]
         );
     }

Model/Action/Erase/CreateAction.php

@@ -37,7 +37,7 @@ public function execute(ActionContextInterface $actionContext): ActionResultInte
             [
                 ArgumentReader::ERASE_ENTITY => $this->eraseManagement->create(
                     ...$this->getArguments($actionContext)
-                )
+                ),
             ]
         );
     }

Model/Action/Export/CreateAction.php

@@ -37,7 +37,7 @@ public function execute(ActionContextInterface $actionContext): ActionResultInte
             [
                 ArgumentReader::EXPORT_ENTITY => $this->exporter->create(
                     ...$this->getArguments($actionContext)
-                )
+                ),
             ]
         );
     }

Model/Action/Export/CreateOrExportAction.php

@@ -38,7 +38,7 @@ public function execute(ActionContextInterface $actionContext): ActionResultInte
             [
                 ExportArgumentReader::EXPORT_ENTITY => $this->exportEntityData->export(
                     ...$this->getArguments($actionContext)
-                )
+                ),
             ]
         );
     }

Model/Action/PerformedBy/AdminUser.php

@@ -34,8 +34,11 @@ public function __construct(
 
     public function get(): string
     {
-        return self::PERFORMED_BY . ($this->authSession->getUser()
-            ? $this->authSession->getUser()->getData($this->attributeName)
-            : '');
+        return self::PERFORMED_BY . $this->resolveUserName();
+    }
+
+    private function resolveUserName(): string
+    {
+        return $this->authSession->getUser() ? $this->authSession->getUser()->getData($this->attributeName) : 'Unknown';
     }
 }

Model/Config/PrivacyMessage.php

@@ -50,13 +50,7 @@ public function __construct(
 
     public function getDisclosureInformationHtml(): string
     {
-        return $this->blockHtml ?? $this->blockHtml = $this->blockFactory->createBlock(
-            Block::class,
-            ['data' => ['block_id' => (string) $this->scopeConfig->getValue(
-                self::CONFIG_PATH_COOKIE_INFORMATION_BLOCK,
-                ScopeInterface::SCOPE_STORE
-            )]]
-        )->toHtml();
+        return $this->blockHtml ?? $this->blockHtml = $this->createDisclosureInformationBlockHtml();
     }
 
     public function getLearnMoreUrl(): string
@@ -66,4 +60,19 @@ public function getLearnMoreUrl(): string
             ScopeInterface::SCOPE_STORE
         )) ?? '#';
     }
+
+    private function createDisclosureInformationBlockHtml(): string
+    {
+        return $this->blockFactory->createBlock(
+            Block::class,
+            [
+                'data' => [
+                    'block_id' => (string) $this->scopeConfig->getValue(
+                        self::CONFIG_PATH_COOKIE_INFORMATION_BLOCK,
+                        ScopeInterface::SCOPE_STORE
+                    ),
+                ],
+            ]
+        )->toHtml();
+    }
 }

Model/Entity/EntityTypeList.php

@@ -40,7 +40,7 @@ public function getEntityTypes(): array
     {
         $entityTypes = [];
 
-        foreach ($this->getList() as $entity => $types) {
+        foreach ($this->getList() as $types) {
             $entityTypes[] = array_keys($types);
         }