return null if value is empty

Author: thomas-kl1

Service/Anonymize/Anonymizer/AlphaLower.php

@@ -37,8 +37,8 @@ public function __construct(
      * @inheritdoc
      * @throws LocalizedException
      */
-    public function anonymize($value): string
+    public function anonymize($value): ?string
     {
-        return $this->mathRandom->getRandomString($this->length, Random::CHARS_LOWERS);
+        return $value ? $this->mathRandom->getRandomString($this->length, Random::CHARS_LOWERS) : null;
     }
 }

Service/Anonymize/Anonymizer/AlphaNum.php

@@ -37,8 +37,8 @@ public function __construct(
      * @inheritdoc
      * @throws LocalizedException
      */
-    public function anonymize($value): string
+    public function anonymize($value): ?string
     {
-        return $this->mathRandom->getRandomString($this->length);
+        return $value ? $this->mathRandom->getRandomString($this->length) : null;
     }
 }

Service/Anonymize/Anonymizer/AlphaUpper.php

@@ -37,8 +37,8 @@ public function __construct(
      * @inheritdoc
      * @throws LocalizedException
      */
-    public function anonymize($value): string
+    public function anonymize($value): ?string
     {
-        return $this->mathRandom->getRandomString($this->length, Random::CHARS_UPPERS);
+        return $value ? $this->mathRandom->getRandomString($this->length, Random::CHARS_UPPERS) : null;
     }
 }

Service/Anonymize/Anonymizer/Anonymous.php

@@ -33,16 +33,16 @@ public function __construct(
      * @inheritdoc
      * @throws LocalizedException
      */
-    public function anonymize($value): string
+    public function anonymize($value): ?string
     {
-        $phrase = new Phrase(
-            self::PHRASE,
-            [
-                $this->mathRandom->getRandomString(self::PREFIX_LENGTH),
-                $this->mathRandom->getRandomString(self::SUFFIX_LENGTH),
-            ]
-        );
-
-        return $phrase->render();
+        return $value
+            ? (new Phrase(
+                self::PHRASE,
+                [
+                    $this->mathRandom->getRandomString(self::PREFIX_LENGTH),
+                    $this->mathRandom->getRandomString(self::SUFFIX_LENGTH),
+                ]
+            ))->render()
+            : null;
     }
 }

Service/Anonymize/Anonymizer/Date.php

@@ -7,9 +7,10 @@
 
 namespace Opengento\Gdpr\Service\Anonymize\Anonymizer;
 
-use Exception;
+use DateTime;
+use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Math\Random;
-use Magento\Framework\Stdlib\DateTime;
+use Magento\Framework\Stdlib\DateTime as StdlibDateTime;
 use Opengento\Gdpr\Service\Anonymize\AnonymizerInterface;
 
 final class Date implements AnonymizerInterface
@@ -19,13 +20,22 @@ final class Date implements AnonymizerInterface
 
     /**
      * @inheritdoc
-     * @throws Exception
+     * @throws LocalizedException
      */
-    public function anonymize($value): string
+    public function anonymize($value): ?string
     {
-        $dateTime = new \DateTime();
+        return $value ? $this->randomDateTime()->format(StdlibDateTime::DATETIME_PHP_FORMAT) : null;
+    }
+
+    /**
+     * @return DateTime
+     * @throws LocalizedException
+     */
+    private function randomDateTime(): DateTime
+    {
+        $dateTime = new DateTime();
         $dateTime->setTimestamp(Random::getRandomNumber(self::MIN_TIMESTAMP, self::MAX_TIMESTAMP));
 
-        return $dateTime->format(DateTime::DATE_PHP_FORMAT);
+        return $dateTime;
     }
 }

Service/Anonymize/Anonymizer/Email.php

@@ -33,16 +33,16 @@ public function __construct(
      * @inheritdoc
      * @throws LocalizedException
      */
-    public function anonymize($value): string
+    public function anonymize($value): ?string
     {
-        $phrase = new Phrase(
-            self::PHRASE,
-            [
-                $this->mathRandom->getRandomString(self::PREFIX_LENGTH, Random::CHARS_LOWERS),
-                $this->mathRandom->getRandomString(self::SUFFIX_LENGTH, Random::CHARS_LOWERS),
-            ]
-        );
-
-        return $phrase->render();
+        return $value
+            ? (new Phrase(
+                self::PHRASE,
+                [
+                    $this->mathRandom->getRandomString(self::PREFIX_LENGTH, Random::CHARS_LOWERS),
+                    $this->mathRandom->getRandomString(self::SUFFIX_LENGTH, Random::CHARS_LOWERS),
+                ]
+            ))->render()
+            : null;
     }
 }

Service/Anonymize/Anonymizer/Entity.php

@@ -48,7 +48,7 @@ public function __construct(
      * @inheritdoc
      * @throws Exception
      */
-    public function anonymize($entity)
+    public function anonymize($entity): object
     {
         if (!is_object($entity)) {
             throw new InvalidArgumentException(

Service/Anonymize/Anonymizer/Number.php

@@ -37,8 +37,8 @@ public function __construct(
      * @inheritdoc
      * @throws LocalizedException
      */
-    public function anonymize($value): int
+    public function anonymize($value): ?int
     {
-        return Random::getRandomNumber($this->min, $this->max);
+        return $value ? Random::getRandomNumber($this->min, $this->max) : null;
     }
 }

Service/Anonymize/Anonymizer/Phone.php

@@ -13,8 +13,8 @@ final class Phone implements AnonymizerInterface
 {
     private const PHONE_NUMBER = '9999999999';
 
-    public function anonymize($value): string
+    public function anonymize($value): ?string
     {
-        return self::PHONE_NUMBER;
+        return $value ? self::PHONE_NUMBER : null;
     }
 }