sugar syntax

Author: thomas-kl1

Block/Adminhtml/Config/Form/Field/Select/OptionSourceSelect.php

@@ -13,17 +13,11 @@
 
 class OptionSourceSelect extends Select
 {
-    /**
-     * @var OptionSourceInterface
-     */
-    private OptionSourceInterface $optionSource;
-
     public function __construct(
         Context $context,
-        OptionSourceInterface $optionSource,
+        private OptionSourceInterface $optionSource,
         array $data = []
     ) {
-        $this->optionSource = $optionSource;
         parent::__construct($context, $data);
     }
 

Block/Adminhtml/Customer/Edit/EraseButton.php

@@ -17,18 +17,12 @@
 
 class EraseButton extends GenericButton implements ButtonProviderInterface
 {
-    private EraseEntityCheckerInterface $eraseCustomerChecker;
-
-    private Config $config;
-
     public function __construct(
         Context $context,
         Registry $registry,
-        EraseEntityCheckerInterface $eraseCustomerChecker,
-        Config $config
+        private EraseEntityCheckerInterface $eraseCustomerChecker,
+        private Config $config
     ) {
-        $this->eraseCustomerChecker = $eraseCustomerChecker;
-        $this->config = $config;
         parent::__construct($context, $registry);
     }
 

Block/Adminhtml/Customer/Edit/ExportButton.php

@@ -16,14 +16,11 @@
 
 class ExportButton extends GenericButton implements ButtonProviderInterface
 {
-    private Config $config;
-
     public function __construct(
         Context $context,
         Registry $registry,
-        Config $config
+        private Config $config
     ) {
-        $this->config = $config;
         parent::__construct($context, $registry);
     }
 

Block/Adminhtml/Order/Edit/EraseButton.php

@@ -16,14 +16,11 @@
 
 class EraseButton extends AbstractBlock
 {
-    private EraseEntityCheckerInterface $eraseEntityChecker;
-
     public function __construct(
         Context $context,
-        EraseEntityCheckerInterface $eraseEntityChecker,
+        private EraseEntityCheckerInterface $eraseEntityChecker,
         array $data = []
     ) {
-        $this->eraseEntityChecker = $eraseEntityChecker;
         parent::__construct($context, $data);
     }
 
@@ -37,7 +34,7 @@ protected function _construct(): void
 
         /** @var View $orderView */
         $orderView = $this->getLayout()->getBlock('sales_order_edit');
-        $orderId = (int) $orderView->getOrderId();
+        $orderId = (int)$orderView->getOrderId();
 
         if ($this->_authorization->isAllowed('Opengento_Gdpr::order_erase') &&
             $this->eraseEntityChecker->canCreate($orderId, 'order')

Block/Adminhtml/Order/Edit/ExportButton.php

@@ -24,7 +24,7 @@ protected function _construct(): void
 
         /** @var View $orderView */
         $orderView = $this->getLayout()->getBlock('sales_order_edit');
-        $orderId = (int) $orderView->getOrderId();
+        $orderId = (int)$orderView->getOrderId();
 
         if ($this->_authorization->isAllowed('Opengento_Gdpr::order_export')) {
             $orderView->addButton(

Controller/Privacy/Erase.php

@@ -41,7 +41,7 @@ protected function isAllowed(): bool
 
     protected function executeAction(): Page|Redirect
     {
-        if ($this->eraseCustomerChecker->exists((int) $this->customerSession->getCustomerId(), 'customer')) {
+        if ($this->eraseCustomerChecker->exists((int)$this->customerSession->getCustomerId(), 'customer')) {
             $this->messageManager->addErrorMessage(new Phrase('Your account is already being removed.'));
             /** @var Redirect $resultRedirect */
             $resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);

Cron/EraseEntityScheduler.php

@@ -83,6 +83,6 @@ private function scheduleEntitiesErasure(): void
 
     private function resolveErasureMaxAge(): int
     {
-        return (int) $this->scopeConfig->getValue(self::CONFIG_PATH_ERASURE_MAX_AGE, ScopeInterface::SCOPE_STORE);
+        return (int)$this->scopeConfig->getValue(self::CONFIG_PATH_ERASURE_MAX_AGE, ScopeInterface::SCOPE_STORE);
     }
 }

Model/Config.php

@@ -51,7 +51,7 @@ public function isErasureEnabled(): bool
      */
     public function getAllowedStatesToErase(): array
     {
-        return explode(',', (string) $this->scopeConfig->getValue(
+        return explode(',', (string)$this->scopeConfig->getValue(
             self::CONFIG_PATH_ERASURE_ALLOWED_STATES,
             ScopeInterface::SCOPE_STORE
         ));

Model/Customer/Anonymize/Processor/CustomerDataProcessor.php

@@ -106,7 +106,7 @@ private function anonymizeCustomer(CustomerInterface $customer): void
         $secureData = $this->customerRegistry->retrieveSecureData($customer->getId());
         $dateTime = (new DateTime())->setTimestamp(PHP_INT_MAX);
         $secureData->setData('lock_expires', $dateTime->format(DateTimeFormat::DATETIME_PHP_FORMAT));
-        $secureData->setPasswordHash(sha1(uniqid((string) mt_rand(), true)));
+        $secureData->setPasswordHash(sha1(uniqid((string)mt_rand(), true)));
 
         $customer = $this->anonymizer->anonymize($customer);
         if ($customer instanceof DataObject) {

Model/Customer/Anonymize/Processor/OrderDataProcessor.php

@@ -58,7 +58,7 @@ public function execute(int $customerId): bool
         foreach ($orderList->getItems() as $order) {
             $lastActive = new DateTime($order->getUpdatedAt());
             $this->salesInformation->isAlive($lastActive)
-                ? $this->salesInformation->scheduleEraseEntity((int) $order->getEntityId(), 'order', $lastActive)
+                ? $this->salesInformation->scheduleEraseEntity((int)$order->getEntityId(), 'order', $lastActive)
                 : $this->anonymize($order);
         }