remove unused argument entity

Author: thomas-kl1

Model/Entity/EntityValue/CustomAttributesProcessor.php

@@ -24,27 +24,12 @@ public function __construct(
         $this->processor = $processor;
     }
 
-    public function process(object $entity, string $key, $values): void
+    public function process(string $key, $values): void
     {
-        if ($this->isValid($entity, $key, $values)) {
+        if ($key === CustomAttributesDataInterface::CUSTOM_ATTRIBUTES && is_iterable($values)) {
             foreach ($values as $value) {
-                $this->processor->process($entity, $key, $value);
+                $this->processor->process($key, $value);
             }
         }
     }
-
-    /**
-     * Check whether the entity object and the value key are valid
-     *
-     * @param object $entity
-     * @param string $key
-     * @param mixed $values
-     * @return bool
-     */
-    private function isValid(object $entity, string $key, $values): bool
-    {
-        return $entity instanceof CustomAttributesDataInterface &&
-            $key === CustomAttributesDataInterface::CUSTOM_ATTRIBUTES &&
-            is_iterable($values);
-    }
 }

Model/Entity/EntityValue/ExtensibleDataProcessor.php

@@ -24,27 +24,12 @@ public function __construct(
         $this->processor = $processor;
     }
 
-    public function process(object $entity, string $key, $values): void
+    public function process(string $key, $values): void
     {
-        if ($this->isValid($entity, $key, $values)) {
+        if ($key === ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY && is_iterable($values)) {
             foreach ($values as $value) {
-                $this->processor->process($entity, $key, $value);
+                $this->processor->process($key, $value);
             }
         }
     }
-
-    /**
-     * Check whether the entity object and the value key are valid
-     *
-     * @param object $entity
-     * @param string $key
-     * @param mixed $values
-     * @return bool
-     */
-    private function isValid(object $entity, string $key, $values): bool
-    {
-        return $entity instanceof ExtensibleDataInterface &&
-            $key === ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY &&
-            is_iterable($values);
-    }
 }

Model/Entity/EntityValue/StrategyProcessor.php

@@ -22,8 +22,8 @@ public function __construct(
         $this->processors = $processors;
     }
 
-    public function process(object $entity, string $key, $value): void
+    public function process(string $key, $value): void
     {
-        ($this->processors[$key] ?? $this->processors['default'])->process($entity, $key, $value);
+        ($this->processors[$key] ?? $this->processors['default'])->process($key, $value);
     }
 }

Model/Entity/EntityValueProcessorInterface.php

@@ -12,11 +12,5 @@
  */
 interface EntityValueProcessorInterface
 {
-    /**
-     * @param object $entity
-     * @param string $key
-     * @param mixed $value
-     * @return void
-     */
-    public function process(object $entity, string $key, $value): void;
+    public function process(string $key, $value): void;
 }

Service/Anonymize/AnonymizerFactory.php

@@ -13,10 +13,7 @@
 
 final class AnonymizerFactory
 {
-    /**
-     * Constants for the anonymizer key codes
-     */
-    public const DEFAULT_ANONYMIZER = 'default';
+    public const DEFAULT_KEY = 'default';
 
     /**
      * @var string[]

Service/Anonymize/Processor/Entity/EntityValue/Processor.php

@@ -40,7 +40,7 @@ public function __construct(
         $this->anonymizer = $anonymizer;
     }
 
-    public function process(object $entity, string $key, $value): void
+    public function process(string $key, $value): void
     {
         if (in_array($key, $this->metadata->getAttributes(), true)) {
             $this->document->addData($key, $this->anonymizer->anonymize($value));

Service/Anonymize/Processor/Entity/EntityValue/SmartProcessor.php

@@ -10,7 +10,6 @@
 use Opengento\Gdpr\Model\Entity\DocumentInterface;
 use Opengento\Gdpr\Model\Entity\EntityValueProcessorInterface;
 use Opengento\Gdpr\Service\Anonymize\AnonymizerFactory;
-use Opengento\Gdpr\Service\Anonymize\AnonymizerInterface;
 use Opengento\Gdpr\Service\Anonymize\MetadataInterface;
 use function in_array;
 
@@ -41,17 +40,15 @@ public function __construct(
         $this->anonymizerFactory = $anonymizerFactory;
     }
 
-    public function process(object $entity, string $key, $value): void
+    public function process(string $key, $value): void
     {
         if (in_array($key, $this->metadata->getAttributes(), true)) {
-            $this->document->addData($key, $this->resolveAnonymizer($key)->anonymize($value));
+            $this->document->addData(
+                $key,
+                $this->anonymizerFactory->get(
+                    $this->metadata->getAnonymizerStrategiesByAttributes()[$key] ?? AnonymizerFactory::DEFAULT_KEY
+                )->anonymize($value)
+            );
         }
     }
-
-    private function resolveAnonymizer(string $key): AnonymizerInterface
-    {
-        return $this->anonymizerFactory->get(
-            $this->metadata->getAnonymizerStrategiesByAttributes()[$key] ?? AnonymizerFactory::DEFAULT_ANONYMIZER
-        );
-    }
 }

Service/Export/Processor/Entity/EntityValue/DataProcessor.php

@@ -32,7 +32,7 @@ public function __construct(
         $this->metadata = $metadata;
     }
 
-    public function process(object $entity, string $key, $value): void
+    public function process(string $key, $value): void
     {
         if (in_array($key, $this->metadata->getAttributes(), true)) {
             $this->document->addData($key, $value);

Service/Export/Processor/Entity/EntityValue/EntityProcessor.php

@@ -40,7 +40,7 @@ public function __construct(
         $this->dataCollector = $dataCollector;
     }
 
-    public function process(object $entity, string $key, $value): void
+    public function process(string $key, $value): void
     {
         if (in_array($key, $this->metadata->getAttributes(), true)) {
             $this->document->addData($key, $this->dataCollector->collect($value));