add object type hint

Author: thomas-kl1

Model/Action/PerformedBy/NotEmptyStrategy.php

@@ -26,14 +26,12 @@ public function __construct(
 
     public function get(): string
     {
-        foreach ($this->performedByList as $performedBy) {
-            $performer = $performedBy->get();
+        $performer = self::PERFORMED_BY;
 
-            if (!empty($performer)) {
-                return $performer;
-            }
+        foreach ($this->performedByList as $performedBy) {
+            $performer = $performedBy->get() ?: $performer;
         }
 
-        return self::PERFORMED_BY;
+        return $performer;
     }
 }

Model/Entity/EntityIterator.php

@@ -42,7 +42,7 @@ public function __construct(
      * @inheritdoc
      * @throws Exception
      */
-    public function iterate($entity): void
+    public function iterate(object $entity): void
     {
         $values = $this->hydratorPool->getHydrator($this->typeResolver->resolve($entity))->extract($entity);
 

Model/Entity/EntityIteratorInterface.php

@@ -12,9 +12,5 @@
  */
 interface EntityIteratorInterface
 {
-    /**
-     * @param object $entity
-     * @return void
-     */
-    public function iterate($entity): void;
+    public function iterate(object $entity): void;
 }

Model/Entity/EntityValue/CustomAttributesProcessor.php

@@ -24,7 +24,7 @@ public function __construct(
         $this->processor = $processor;
     }
 
-    public function process($entity, string $key, $values): void
+    public function process(object $entity, string $key, $values): void
     {
         if ($this->isValid($entity, $key, $values)) {
             foreach ($values as $value) {
@@ -41,7 +41,7 @@ public function process($entity, string $key, $values): void
      * @param mixed $values
      * @return bool
      */
-    private function isValid($entity, string $key, $values): bool
+    private function isValid(object $entity, string $key, $values): bool
     {
         return $entity instanceof CustomAttributesDataInterface &&
             $key === CustomAttributesDataInterface::CUSTOM_ATTRIBUTES &&

Model/Entity/EntityValue/ExtensibleDataProcessor.php

@@ -24,7 +24,7 @@ public function __construct(
         $this->processor = $processor;
     }
 
-    public function process($entity, string $key, $values): void
+    public function process(object $entity, string $key, $values): void
     {
         if ($this->isValid($entity, $key, $values)) {
             foreach ($values as $value) {
@@ -41,7 +41,7 @@ public function process($entity, string $key, $values): void
      * @param mixed $values
      * @return bool
      */
-    private function isValid($entity, string $key, $values): bool
+    private function isValid(object $entity, string $key, $values): bool
     {
         return $entity instanceof ExtensibleDataInterface &&
             $key === ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY &&

Model/Entity/EntityValue/StrategyProcessor.php

@@ -8,9 +8,6 @@
 namespace Opengento\Gdpr\Model\Entity\EntityValue;
 
 use Opengento\Gdpr\Model\Entity\EntityValueProcessorInterface;
-use function array_combine;
-use function array_keys;
-use function array_values;
 
 final class StrategyProcessor implements EntityValueProcessorInterface
 {
@@ -25,7 +22,7 @@ public function __construct(
         $this->processors = $processors;
     }
 
-    public function process($entity, string $key, $value): void
+    public function process(object $entity, string $key, $value): void
     {
         ($this->processors[$key] ?? $this->processors['default'])->process($entity, $key, $value);
     }

Model/Entity/EntityValueProcessorInterface.php

@@ -18,5 +18,5 @@ interface EntityValueProcessorInterface
      * @param mixed $value
      * @return void
      */
-    public function process($entity, string $key, $value): void;
+    public function process(object $entity, string $key, $value): void;
 }

Model/Entity/SourceProvider/ModifierComposite.php

@@ -11,7 +11,6 @@
 use Magento\Framework\Data\Collection;
 
 /**
- * Class ModifierComposite
  * @api
  */
 final class ModifierComposite implements ModifierInterface

Service/Anonymize/Processor/Entity/EntityValue/Processor.php

@@ -40,7 +40,7 @@ public function __construct(
         $this->anonymizer = $anonymizer;
     }
 
-    public function process($entity, string $key, $value): void
+    public function process(object $entity, string $key, $value): void
     {
         if (in_array($key, $this->metadata->getAttributes(), true)) {
             $this->document->addData($key, $this->anonymizer->anonymize($value));

Service/Anonymize/Processor/Entity/EntityValue/SmartProcessor.php

@@ -41,7 +41,7 @@ public function __construct(
         $this->anonymizerFactory = $anonymizerFactory;
     }
 
-    public function process($entity, string $key, $value): void
+    public function process(object $entity, string $key, $value): void
     {
         if (in_array($key, $this->metadata->getAttributes(), true)) {
             $this->document->addData($key, $this->resolveAnonymizer($key)->anonymize($value));