Skip to content

Commit 0f06c2e

Browse files
thomas-kl1thomas-kl1
committed
rename excessive long variables
1 parent 75af759 commit 0f06c2e

File tree

15 files changed

+61
-61
lines changed

15 files changed

+61
-61
lines changed

‎Cron/ExportEntity.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ final class ExportEntity
3838
/**
3939
* @var ExportEntityManagementInterface
4040
*/
41-
private $entityManagement;
41+
private $exportManagement;
4242

4343
/**
4444
* @var SearchCriteriaBuilder
@@ -49,13 +49,13 @@ public function __construct(
4949
LoggerInterface $logger,
5050
Config $config,
5151
ExportEntityRepositoryInterface $exportRepository,
52-
ExportEntityManagementInterface $entityManagement,
52+
ExportEntityManagementInterface $exportManagement,
5353
SearchCriteriaBuilder $criteriaBuilder
5454
) {
5555
$this->logger = $logger;
5656
$this->config = $config;
5757
$this->exportRepository = $exportRepository;
58-
$this->entityManagement = $entityManagement;
58+
$this->exportManagement = $exportManagement;
5959
$this->criteriaBuilder = $criteriaBuilder;
6060
}
6161

@@ -69,7 +69,7 @@ public function execute(): void
6969
$exportList = $this->exportRepository->getList($this->criteriaBuilder->create());
7070

7171
foreach ($exportList->getItems() as $exportEntity) {
72-
$this->entityManagement->export($exportEntity);
72+
$this->exportManagement->export($exportEntity);
7373
}
7474
} catch (Exception $e) {
7575
$this->logger->error($e->getMessage(), $e->getTrace());

‎Model/Action/Erase/CancelAction.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ final class CancelAction extends AbstractAction
2929
/**
3030
* @var EraseEntityManagementInterface
3131
*/
32-
private $entityManagement;
32+
private $eraseManagement;
3333

3434
public function __construct(
3535
ResultBuilder $resultBuilder,
3636
EraseEntityRepositoryInterface $eraseRepository,
37-
EraseEntityManagementInterface $entityManagement
37+
EraseEntityManagementInterface $eraseManagement
3838
) {
3939
$this->eraseRepository = $eraseRepository;
40-
$this->entityManagement = $entityManagement;
40+
$this->eraseManagement = $eraseManagement;
4141
parent::__construct($resultBuilder);
4242
}
4343

@@ -48,7 +48,7 @@ public function execute(ActionContextInterface $actionContext): ActionResultInte
4848
return $this->createActionResult(
4949
[
5050
ArgumentReader::ERASE_ENTITY => $this->resolveEntity(...$arguments),
51-
'canceled' => $this->entityManagement->cancel(...$arguments)
51+
'canceled' => $this->eraseManagement->cancel(...$arguments)
5252
]
5353
);
5454
}

‎Model/Action/Erase/CreateAction.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,21 @@ final class CreateAction extends AbstractAction
2121
/**
2222
* @var EraseEntityManagementInterface
2323
*/
24-
private $entityManagement;
24+
private $eraseManagement;
2525

2626
public function __construct(
2727
ResultBuilder $resultBuilder,
28-
EraseEntityManagementInterface $entityManagement
28+
EraseEntityManagementInterface $eraseManagement
2929
) {
30-
$this->entityManagement = $entityManagement;
30+
$this->eraseManagement = $eraseManagement;
3131
parent::__construct($resultBuilder);
3232
}
3333

3434
public function execute(ActionContextInterface $actionContext): ActionResultInterface
3535
{
3636
return $this->createActionResult(
3737
[
38-
ArgumentReader::ERASE_ENTITY => $this->entityManagement->create(
38+
ArgumentReader::ERASE_ENTITY => $this->eraseManagement->create(
3939
...$this->getArguments($actionContext)
4040
)
4141
]

‎Model/Action/Erase/ExecuteAction.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ final class ExecuteAction extends AbstractAction
1919
/**
2020
* @var EraseEntityManagementInterface
2121
*/
22-
private $entityManagement;
22+
private $eraseManagement;
2323

2424
public function __construct(
2525
ResultBuilder $resultBuilder,
26-
EraseEntityManagementInterface $entityManagement
26+
EraseEntityManagementInterface $eraseManagement
2727
) {
28-
$this->entityManagement = $entityManagement;
28+
$this->eraseManagement = $eraseManagement;
2929
parent::__construct($resultBuilder);
3030
}
3131

@@ -38,7 +38,7 @@ public function execute(ActionContextInterface $actionContext): ActionResultInte
3838
}
3939

4040
return $this->createActionResult(
41-
[ArgumentReader::ERASE_ENTITY => $this->entityManagement->process($eraseEntity)]
41+
[ArgumentReader::ERASE_ENTITY => $this->eraseManagement->process($eraseEntity)]
4242
);
4343
}
4444
}

‎Model/Action/Export/ExportAction.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ final class ExportAction extends AbstractAction
2020
/**
2121
* @var ExportEntityManagementInterface
2222
*/
23-
private $entityManagement;
23+
private $exportManagement;
2424

2525
public function __construct(
2626
ResultBuilder $resultBuilder,
27-
ExportEntityManagementInterface $entityManagement
27+
ExportEntityManagementInterface $exportManagement
2828
) {
29-
$this->entityManagement = $entityManagement;
29+
$this->exportManagement = $exportManagement;
3030
parent::__construct($resultBuilder);
3131
}
3232

@@ -39,7 +39,7 @@ public function execute(ActionContextInterface $actionContext): ActionResultInte
3939
}
4040

4141
return $this->createActionResult(
42-
[ExportArgumentReader::EXPORT_ENTITY => $this->entityManagement->export($exportEntity)]
42+
[ExportArgumentReader::EXPORT_ENTITY => $this->exportManagement->export($exportEntity)]
4343
);
4444
}
4545
}

‎Model/Config/Source/EraseComponents.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ final class EraseComponents implements OptionSourceInterface
2525
*
2626
* @var string
2727
*/
28-
private $resolverFactoryClassName;
28+
private $factoryClassName;
2929

3030
/**
3131
* @var string[][]
@@ -34,10 +34,10 @@ final class EraseComponents implements OptionSourceInterface
3434

3535
public function __construct(
3636
ConfigInterface $objectManagerConfig,
37-
string $resolverFactoryClassName
37+
string $factoryClassName
3838
) {
3939
$this->objectManagerConfig = $objectManagerConfig;
40-
$this->resolverFactoryClassName = $resolverFactoryClassName;
40+
$this->factoryClassName = $factoryClassName;
4141
}
4242

4343
public function toOptionArray(): array
@@ -58,7 +58,7 @@ private function retrieveDelegateProcessors(): array
5858
{
5959
$delegateProcessors = [];
6060
/** @var string[] $resolvers */
61-
$resolvers = $this->retrieveArgument($this->resolverFactoryClassName, 'processorResolvers', []);
61+
$resolvers = $this->retrieveArgument($this->factoryClassName, 'processorResolvers', []);
6262

6363
foreach ($resolvers as $resolver) {
6464
$delegateProcessors[] = $this->retrieveArgument($resolver, 'processors');

‎Model/Customer/SourceProvider/FilterModifier.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ public function apply(Collection $collection, Filter $filter): void
2323
if ($collection instanceof Collection\AbstractDb && $filter->getField() === 'created_at') {
2424
$connection = $collection->getConnection();
2525

26-
$customerVisitorSelect = $connection->select()
26+
$visitorSelect = $connection->select()
2727
->from($connection->getTableName('customer_visitor'))
2828
->columns(['customer_id' => 'customer_id', 'last_visit_at' => 'MAX(last_visit_at)'])
2929
->group(['customer_id']);
3030

3131
$collection->getSelect()->joinLeft(
32-
['cv' => $customerVisitorSelect],
32+
['cv' => $visitorSelect],
3333
'main_table.entity_id=cl.customer_id',
3434
null
3535
);

‎Model/Erase/EraseEntityScheduler.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ final class EraseEntityScheduler
2020
/**
2121
* @var SourceProviderFactory
2222
*/
23-
private $sourceProviderFactory;
23+
private $srcProviderFactory;
2424

2525
/**
2626
* @var ModifierFactory
@@ -33,11 +33,11 @@ final class EraseEntityScheduler
3333
private $eraseManagement;
3434

3535
public function __construct(
36-
SourceProviderFactory $sourceProviderFactory,
36+
SourceProviderFactory $srcProviderFactory,
3737
ModifierFactory $modifierFactory,
3838
EraseEntityManagementInterface $eraseManagement
3939
) {
40-
$this->sourceProviderFactory = $sourceProviderFactory;
40+
$this->srcProviderFactory = $srcProviderFactory;
4141
$this->modifierFactory = $modifierFactory;
4242
$this->eraseManagement = $eraseManagement;
4343
}
@@ -69,7 +69,7 @@ public function schedule(array $entityTypes, Filter $filter): void
6969
private function collectEntityIds(array $entityTypes, Filter $filter): Generator
7070
{
7171
foreach ($entityTypes as $entityType) {
72-
$source = $this->sourceProviderFactory->create($entityType);
72+
$source = $this->srcProviderFactory->create($entityType);
7373
$this->modifierFactory->get($entityType)->apply($source, $filter);
7474

7575
yield $entityType => $source->getAllIds();

‎Model/Erase/SecureEraseEntityManagement.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,25 @@ final class SecureEraseEntityManagement implements EraseEntityManagementInterfac
1818
/**
1919
* @var EraseEntityManagementInterface
2020
*/
21-
private $entityManagement;
21+
private $eraseManagement;
2222

2323
/**
2424
* @var EraseEntityCheckerInterface
2525
*/
2626
private $eraseEntityChecker;
2727

2828
public function __construct(
29-
EraseEntityManagementInterface $entityManagement,
29+
EraseEntityManagementInterface $eraseManagement,
3030
EraseEntityCheckerInterface $eraseEntityChecker
3131
) {
32-
$this->entityManagement = $entityManagement;
32+
$this->eraseManagement = $eraseManagement;
3333
$this->eraseEntityChecker = $eraseEntityChecker;
3434
}
3535

3636
public function create(int $entityId, string $entityType): EraseEntityInterface
3737
{
3838
if ($this->eraseEntityChecker->canCreate($entityId, $entityType)) {
39-
return $this->entityManagement->create($entityId, $entityType);
39+
return $this->eraseManagement->create($entityId, $entityType);
4040
}
4141

4242
throw new LocalizedException(
@@ -49,7 +49,7 @@ public function create(int $entityId, string $entityType): EraseEntityInterface
4949
public function cancel(int $entityId, string $entityType): bool
5050
{
5151
if ($this->eraseEntityChecker->canCancel($entityId, $entityType)) {
52-
return $this->entityManagement->cancel($entityId, $entityType);
52+
return $this->eraseManagement->cancel($entityId, $entityType);
5353
}
5454

5555
throw new LocalizedException(new Phrase('The erasure process is running and cannot be undone.'));
@@ -58,7 +58,7 @@ public function cancel(int $entityId, string $entityType): bool
5858
public function process(EraseEntityInterface $entity): EraseEntityInterface
5959
{
6060
if ($this->eraseEntityChecker->canProcess($entity->getEntityId(), $entity->getEntityType())) {
61-
return $this->entityManagement->process($entity);
61+
return $this->eraseManagement->process($entity);
6262
}
6363

6464
throw new LocalizedException(new Phrase('Impossible to process the erasure, there is still pending orders.'));

‎Model/Export/ExportEntityData.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ final class ExportEntityData
2929
/**
3030
* @var ExportEntityManagementInterface
3131
*/
32-
private $entityManagement;
32+
private $exportManagement;
3333

3434
/**
3535
* @var ExportEntityCheckerInterface
@@ -38,11 +38,11 @@ final class ExportEntityData
3838

3939
public function __construct(
4040
ExportEntityRepositoryInterface $exportRepository,
41-
ExportEntityManagementInterface $entityManagement,
41+
ExportEntityManagementInterface $exportManagement,
4242
ExportEntityCheckerInterface $exportEntityChecker
4343
) {
4444
$this->exportRepository = $exportRepository;
45-
$this->entityManagement = $entityManagement;
45+
$this->exportManagement = $exportManagement;
4646
$this->exportEntityChecker = $exportEntityChecker;
4747
}
4848

@@ -61,11 +61,11 @@ public function export(int $entityId, string $entityType): ExportEntityInterface
6161
try {
6262
$exportEntity = $this->exportRepository->getByEntity($entityId, $entityType);
6363
} catch (NoSuchEntityException $e) {
64-
$exportEntity = $this->entityManagement->create($entityId, $entityType);
64+
$exportEntity = $this->exportManagement->create($entityId, $entityType);
6565
}
6666

6767
return $this->exportEntityChecker->isExported($entityId, $entityType)
6868
? $exportEntity
69-
: $this->entityManagement->export($exportEntity);
69+
: $this->exportManagement->export($exportEntity);
7070
}
7171
}

0 commit comments

Comments
 (0)