fix converter type & code format

Author: thomas-kl1

Model/Config/DocumentType/Converter.php

@@ -33,13 +33,15 @@ public function convert($source): array
         }
 
         $documentTypes = [];
+        $defaultConverter = $this->nodeConverters['default'];
 
         /** @var DOMElement $documentType */
         foreach ($source->getElementsByTagName('documentType') as $documentType) {
             $data = [];
             /** @var DOMNode $node */
             foreach ($documentType->childNodes as $node) {
-                $data[SimpleDataObjectConverter::camelCaseToSnakeCase($node->nodeName)] = $this->convertNode($node);
+                $converter = $this->nodeConverters[$node->nodeName] ?? $defaultConverter;
+                $data[SimpleDataObjectConverter::camelCaseToSnakeCase($node->nodeName)] = $converter->convert($node);
             }
 
             $data['code'] = $documentType->getAttribute('code');
@@ -48,9 +50,4 @@ public function convert($source): array
 
         return $documentTypes;
     }
-
-    private function convertNode(DOMNode $node): string
-    {
-        return ($this->nodeConverters[$node->nodeName] ?? $this->nodeConverters['default'])->convert($node);
-    }
 }

Model/Config/DocumentType/Converter/NodeConverterInterface.php

@@ -11,5 +11,5 @@
 
 interface NodeConverterInterface
 {
-    public function convert(DOMNode $node): string;
+    public function convert(DOMNode $node);
 }

Model/Config/DocumentType/Converter/ScheduledImportConverter.php

@@ -0,0 +1,30 @@
+<?php
+/**
+ * Copyright © OpenGento, All rights reserved.
+ * See LICENSE bundled with this library for license details.
+ */
+declare(strict_types=1);
+
+namespace Opengento\Document\Model\Config\DocumentType\Converter;
+
+use DOMNode;
+use Magento\Framework\Stdlib\BooleanUtils;
+
+final class ScheduledImportConverter implements NodeConverterInterface
+{
+    /**
+     * @var BooleanUtils
+     */
+    private $booleanUtils;
+
+    public function __construct(
+        BooleanUtils $booleanUtils
+    ) {
+        $this->booleanUtils = $booleanUtils;
+    }
+
+    public function convert(DOMNode $node): bool
+    {
+        return $this->booleanUtils->toBoolean($node->nodeValue);
+    }
+}

etc/di.xml

@@ -208,6 +208,7 @@
         <arguments>
             <argument name="nodeConverters" xsi:type="array">
                 <item name="default" xsi:type="object">Opengento\Document\Model\Config\DocumentType\Converter\NodeConverter</item>
+                <item name="scheduledImport" xsi:type="object">Opengento\Document\Model\Config\DocumentType\Converter\ScheduledImportConverter</item>
                 <item name="fileAllowedExtensionsComplex" xsi:type="object">Opengento\Document\Model\Config\DocumentType\Converter\FileAllowedExtensionsConverter</item>
             </argument>
         </arguments>

view/adminhtml/ui_component/document_form.xml

@@ -75,6 +75,7 @@
                 <visible>true</visible>
                 <validation>
                     <rule name="required-entry" xsi:type="boolean">true</rule>
+                    <rule name="validate-identifier" xsi:type="boolean">true</rule>
                 </validation>
                 <dataScope>code</dataScope>
             </settings>

view/adminhtml/ui_component/document_type_form.xml

@@ -57,6 +57,7 @@
                 <visible>true</visible>
                 <validation>
                     <rule name="required-entry" xsi:type="boolean">true</rule>
+                    <rule name="validate-identifier" xsi:type="boolean">true</rule>
                 </validation>
                 <dataScope>code</dataScope>
             </settings>