Skip to content

Commit 299d536

Browse files
committed
🐛(frontend) fix svg icons import on videoplayer control bar
Since the Vite upgrade from 5.4.9 to 6.0.1, the download, transcript and shared media icons were missing from the video player control bar on the standalone site. Based on the Vite documentation (https://vite.dev/guide/assets), when inlining SVGs through url(), the variable needs to be wrapped within double quotes.
1 parent 4e34762 commit 299d536

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).
88

99
## [Unreleased]
1010

11+
### Fixed
12+
13+
- Restore download, transcription and shared media icons on the video player
14+
1115
## [5.6.0] - 2025-03-06
1216

1317
### Added

src/frontend/packages/lib_video/src/components/common/VideoPlayer/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,19 @@ export const StyledBox = styled(Box)`
3939
}
4040
4141
.vjs-icon-download {
42-
background-image: url(${DownloadIcon});
42+
background-image: url(\"${DownloadIcon}\");
4343
background-repeat: no-repeat;
4444
background-position: center;
4545
}
4646
4747
.vjs-icon-transcript {
48-
background-image: url(${TranscriptIcon});
48+
background-image: url(\"${TranscriptIcon}\");
4949
background-repeat: no-repeat;
5050
background-position: center;
5151
}
5252
5353
.vjs-icon-shared-media {
54-
background-image: url(${SharedMediaIcon});
54+
background-image: url(\"${SharedMediaIcon}\");
5555
background-repeat: no-repeat;
5656
background-position: center;
5757
}

0 commit comments

Comments
 (0)