Skip to content

ParameterNode.get_descendants doesn't include ParameterScale rates and thresholds #1112

@nikhilwoodruff

Description

@nikhilwoodruff

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

Called ParameterNode.get_descendants in a tree with a parameter scale.

Here is what I expected to happen:

Expected an iterator including rates and thresholds from ParameterScale parameters.

Here is what actually happened:

The iterator didn't include the scale parameters.

Here is data (or links to it) that can help you reproduce this issue:

I've written a MWE here on Google Colab.

Context

I identify more as a:

  • Developer (I create tools that use the existing OpenFisca code).

Thanks! Happy to tackle this with a PR if desired. (cc @benjello @sandcha)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions