Skip to content

Commit 565bbaf

Browse files
committed
Consistent use of remove/delete/rm for secrets/fns/namespaces
Consistent "delete", "remove", and "rm" usage for secrets, functions, and namespaces. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
1 parent f509dd3 commit 565bbaf

File tree

4 files changed

+16
-60
lines changed

4 files changed

+16
-60
lines changed

commands/namespace_delete.go renamed to commands/namespace_remove.go

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,21 @@ import (
1010
"github.com/spf13/cobra"
1111
)
1212

13-
var namespaceDeleteCmd = &cobra.Command{
14-
Use: `delete NAME`,
15-
Short: "Delete existing namespace",
16-
Long: "Delete existing namespace",
17-
Example: ` faas-cli namespace delete NAME`,
18-
RunE: deleteNamespace,
19-
PreRunE: preDeleteNamespace,
13+
var namespaceRemoveCmd = &cobra.Command{
14+
Use: `remove NAME`,
15+
Short: "Remove existing namespace",
16+
Long: "Remove existing namespace",
17+
Example: ` faas-cli namespace remove NAME`,
18+
Aliases: []string{"rm", "delete"},
19+
RunE: removeNamespace,
20+
PreRunE: preRemoveNamespace,
2021
}
2122

2223
func init() {
23-
namespaceCmd.AddCommand(namespaceDeleteCmd)
24+
namespaceCmd.AddCommand(namespaceRemoveCmd)
2425
}
2526

26-
func preDeleteNamespace(cmd *cobra.Command, args []string) error {
27+
func preRemoveNamespace(cmd *cobra.Command, args []string) error {
2728
if len(args) == 0 {
2829
return fmt.Errorf("namespace name required")
2930
}
@@ -35,7 +36,7 @@ func preDeleteNamespace(cmd *cobra.Command, args []string) error {
3536
return nil
3637
}
3738

38-
func deleteNamespace(cmd *cobra.Command, args []string) error {
39+
func removeNamespace(cmd *cobra.Command, args []string) error {
3940
client, err := GetDefaultSDKClient()
4041
if err != nil {
4142
return err
@@ -48,7 +49,7 @@ func deleteNamespace(cmd *cobra.Command, args []string) error {
4849
return err
4950
}
5051

51-
fmt.Printf("Namespace Deleted: %s\n", ns)
52+
fmt.Printf("Namespace Removed: %s\n", ns)
5253

5354
return nil
5455
}

commands/namespace_delete_test.go renamed to commands/namespace_remove_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package commands
33
import "testing"
44

55
func Test_preDeleteNamespace_NoArgs_Fails(t *testing.T) {
6-
res := preDeleteNamespace(nil, []string{})
6+
res := preRemoveNamespace(nil, []string{})
77

88
want := "namespace name required"
99
if res.Error() != want {
@@ -12,7 +12,7 @@ func Test_preDeleteNamespace_NoArgs_Fails(t *testing.T) {
1212
}
1313

1414
func Test_preDeleteNamespace_MoreThan1Arg_Fails(t *testing.T) {
15-
res := preDeleteNamespace(nil, []string{
15+
res := preRemoveNamespace(nil, []string{
1616
"secret1",
1717
"secret2",
1818
})
@@ -24,7 +24,7 @@ func Test_preDeleteNamespace_MoreThan1Arg_Fails(t *testing.T) {
2424
}
2525

2626
func Test_preDeleteNamespace_ExtactlyOneArgIsFine(t *testing.T) {
27-
res := preDeleteNamespace(nil, []string{
27+
res := preRemoveNamespace(nil, []string{
2828
"namespace1",
2929
})
3030

commands/secret_remove.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import (
1515

1616
var secretRemoveCmd = &cobra.Command{
1717
Use: "remove [--tls-no-verify]",
18-
Aliases: []string{"rm"},
18+
Aliases: []string{"rm", "delete"},
1919
Short: "remove a secret",
2020
Long: `Remove a secret by name`,
2121
Example: `faas-cli secret remove NAME

schema/openfaas/v1alpha2/crd.go

Lines changed: 0 additions & 45 deletions
This file was deleted.

0 commit comments

Comments
 (0)