Latest plugin version still uses Moodle Events API v1

[mwillis11]

Hi,

I see that a kind soul committed some changes to update the Events API v1 use to use v2 in #44, which was rejected in 2017: #44 (comment)

Merged another pull request for Events 2 API

There is no reference to the ticket that 'fixed' this.

I've just updated my local moodle instance to the release 1.3.1 (I'm using Moodle 4.1.16) then purged caches, and I still get the Site Administration > Notifications warning banner saying mod_equella is using Events API 1.

Looking through the source code, there are calls to events_trigger() function in callbackmulti.php and externallib.php:
https://github.com/search?q=repo%3Aopenequella%2Fmoodle-mod_openEQUELLA%20events_trigger&type=code

I can't find an existing ticket here to update the API use. Is there a different branch I should use?

Thanks in advance!

[mwillis11]

Looking at this further,

Moodle complains about this because there are still two records in the events_handlers table for mod_equella after updating to the latest version. For the record, I updated from version 2016031000 to the latest version, as mentioned above.

Edit, I think my org installed 'this' plugin from a different repo: https://github.com/ffhuber/mdl-mod-ply - that is the only one with that version number in the version.php history. Regardless, I think the upgrade to 1.3.1 in this repo from that version still went smoothly, apart from one issue

The /db/upgrade.php script does not delete from this table like other plugins when updating their Events API 1 > 2 usages.

When an admin user then loads the `/moodle/admin/index.php' page, Moodle finds results when calling the following ~ line 905:

// Check if there are events 1 API handlers.
$eventshandlers = $DB->get_records_sql('SELECT DISTINCT component FROM {events_handlers}');

^ eventually used in call to moodle/admin/renderer.php line 672

public function events_handlers($eventshandlers) {
    if ($eventshandlers) {
        $components = '';
        foreach ($eventshandlers as $eventhandler) {
            $components .= $eventhandler->component . ', ';
        }
        $components = rtrim($components, ', ');
        return $this->warning(get_string('eventshandlersinuse', 'admin', $components));
    }
}

I think the fix is just whacking this in the moodle/mod/equella/db/upgrade.php file inside the most appropriate if ($oldversion < 1234567890) { block(s):

$DB->execute("DELETE FROM {events_handlers} WHERE component = 'mod_equella'");

[edalex-ian]

Hi @mwillis11 ,

I had a look in the history, and I think the other mentioned pull request was #42 .

But onto the specific items you've mentioned above. We're targetting a couple of releases this year, so we'll see if we can't look into what you've raised above as part of those efforts.

Thank you very much for taking the time to raise the issue.

CC: @PenghaiZhang and @edalex-siddharth

[edalex-siddharth]

@edalex-ian I will investigate this issue