OEP-32 has been superseded and should be updated

[e0d]

The guidance for external ids in OEP-32 is currently incorrect and that OEP has been superseded by this ADR.

The OEP needs a significant rework.

[robrap]

Do you think the guidance is still correct for ids internal to the platform, and this is just about correcting guidance for external ids?

[e0d]

The ADR only covers the case of external IDs. So, job one would be correcting that.

My preference would be that auto increment database IDs were not used as identifiers, but that's a much bigger, breaking, change I believe.

[robrap]

I agree with your preference, but the point of the OEP was to codify what to use, given the reality of our situation. Better than using user id in some cases, and username in other cases, as was happening.

[sarina]

@robrap @e0d - is OEP-32 completely incorrect and should be marked as Obsolete, or is it simply that parts need updating?

[robrap]

It is partially correct. It is valid for internal ids, and invalid for external ids. I'm not sure if there are legacy exceptions to the external ids case that do use this same internal id.

[sarina]

Thanks. Assuming #586 passes, I will mark this OEP as Needs Revision and point to this thread.

[sarina]

Put OEP-32 in Needs Revision status, please take a look at #603 - this ticket will be kept open for discussion on how to actually update the OEP for real

[sarina]

Updating Feb 2025 as part of my OEP cleanup. This issue still needs to be addressed. I don't feel I have the context or ability to do so. Is there anyone I could tag who might have the context & capacity to make this update?

[robrap]

@sarina: I added some comments to #603 before realizing it was approved/merged. We could consider updating again.

Other than that, I'm not sure how urgent/important it is to turn the note you added into the OEP into a more complete update. I'll leave that to @e0d to decide, and determine whether to leave open this issue. I imagine the note is good enough for quite a while, so I don't feel any burning desire to do the update myself.