Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Commit ea63b55

Browse files
authored
Adds support for Kibana 7.7.0 (#151)
* Adds support for Kibana 7.7.0 * upgrade Kibana version in workflow * Updates the Release Notes * remove usage of getAxisId(), getSpecId() and getAnnotationId()
1 parent 11e1c62 commit ea63b55

File tree

10 files changed

+28
-45
lines changed

10 files changed

+28
-45
lines changed

.github/workflows/unit-tests-workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
uses: actions/checkout@v2
1414
with:
1515
repository: opendistro-for-elasticsearch/kibana-oss
16-
ref: 7.6.1
16+
ref: 7.7.0
1717
token: ${{ secrets.GITHUB_KIBANA_OSS }}
1818
path: kibana
1919
- name: Get node and yarn versions

opendistro-elasticsearch-alerting-kibana.release-notes.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## Version 1.8.0.0, 2020-05-19
2+
3+
### Bug fixes
4+
* Fixes wrong time interval unit for monitor on top of anomaly detector. - [PR #145](https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/145)
5+
16
## Version 1.7.0.0, 2020-05-04
27

38
### New Features

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"name": "opendistro-alerting",
3-
"version": "1.7.0.0",
3+
"version": "1.8.0.0",
44
"description": "Kibana Alerting Plugin",
55
"main": "index.js",
66
"license": "Apache-2.0",
77
"homepage": "https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin",
88
"kibana": {
9-
"version": "7.6.1",
9+
"version": "7.7.0",
1010
"templateVersion": "6.3.3"
1111
},
1212
"repository": {

public/pages/CreateMonitor/components/AnomalyDetectors/AnomaliesChart/AnomaliesChart.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,11 @@ import PropTypes from 'prop-types';
1818
import { EuiText, EuiSpacer } from '@elastic/eui';
1919
import {
2020
Chart,
21-
getAxisId,
2221
Axis,
23-
getSpecId,
2422
LineSeries,
2523
niceTimeFormatter,
2624
Settings,
2725
Position,
28-
getAnnotationId,
2926
LineAnnotation,
3027
} from '@elastic/charts';
3128
import { ChartContainer } from '../../../../../components/ChartContainer/ChartContainer';
@@ -62,16 +59,16 @@ const AnomaliesChart = props => {
6259
showLegendDisplayValue={false}
6360
/>
6461
) : null}
65-
<Axis id={getAxisId('bottom')} position="bottom" tickFormat={timeFormatter} />
62+
<Axis id="bottom" position="bottom" tickFormat={timeFormatter} />
6663
<Axis
67-
id={getAxisId('left')}
64+
id="left"
6865
title={getAxisTitle(props.displayGrade, props.displayConfidence)}
6966
position="left"
7067
domain={{ min: 0, max: 1 }}
7168
/>
7269
{props.annotationData ? (
7370
<LineAnnotation
74-
annotationId={getAnnotationId('anomalyAnnotation')}
71+
annotationId="anomalyAnnotation"
7572
domainType="yDomain"
7673
dataValues={props.annotationData}
7774
style={{
@@ -84,7 +81,7 @@ const AnomaliesChart = props => {
8481
) : null}
8582
{props.displayGrade ? (
8683
<LineSeries
87-
id={getSpecId('Anomaly grade')}
84+
id="Anomaly grade"
8885
xScaleType="time"
8986
yScaleType="linear"
9087
xAccessor={'plotTime'}
@@ -94,7 +91,7 @@ const AnomaliesChart = props => {
9491
) : null}
9592
{props.displayConfidence ? (
9693
<LineSeries
97-
id={getSpecId('Confidence')}
94+
id="Confidence"
9895
xScaleType="time"
9996
yScaleType="linear"
10097
xAccessor={'plotTime'}

public/pages/CreateMonitor/components/AnomalyDetectors/FeatureChart/FeatureChart.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,7 @@
1515

1616
import React from 'react';
1717
import PropTypes from 'prop-types';
18-
import {
19-
Chart,
20-
Axis,
21-
LineSeries,
22-
getSpecId,
23-
getAxisId,
24-
RectAnnotation,
25-
getAnnotationId,
26-
niceTimeFormatter,
27-
} from '@elastic/charts';
18+
import { Chart, Axis, LineSeries, RectAnnotation, niceTimeFormatter } from '@elastic/charts';
2819
import { EuiPagination, EuiText, EuiFlexGroup, EuiFlexItem, EuiSpacer } from '@elastic/eui';
2920
import DelayedLoader from '../../../../../components/DelayedLoader';
3021
import { ChartContainer } from '../../../../../components/ChartContainer/ChartContainer';
@@ -70,17 +61,17 @@ class FeatureChart extends React.Component {
7061
<Chart>
7162
<RectAnnotation
7263
dataValues={annotations || []}
73-
annotationId={getAnnotationId('react')}
64+
annotationId="react"
7465
style={{
7566
stroke: '#FCAAAA',
7667
strokeWidth: 1.5,
7768
fill: '#FCAAAA',
7869
}}
7970
/>
80-
<Axis id={getAxisId('left')} title={currentFeature.featureName} position="left" />
81-
<Axis id={getAxisId('bottom')} position="bottom" tickFormat={timeFormatter} />
71+
<Axis id="left" title={currentFeature.featureName} position="left" />
72+
<Axis id="bottom" position="bottom" tickFormat={timeFormatter} />
8273
<LineSeries
83-
id={getSpecId('lines')}
74+
id="lines"
8475
xScaleType="time"
8576
yScaleType="linear"
8677
xAccessor={'startTime'}

public/pages/CreateMonitor/components/Schedule/Frequencies/__snapshots__/Frequencies.test.js.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ exports[`Frequencies renders CustomCron 1`] = `
9898
style="font-size:14px;display:inline-block"
9999
>
100100
<input
101+
aria-controls=""
101102
data-test-subj="comboBoxSearchInput"
102103
id="timezone"
103104
role="textbox"

public/pages/CreateMonitor/containers/AnomalyDetectors/__tests__/__snapshots__/AnomalyDetector.test.js.snap

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,7 @@ exports[`AnomalyDetectors renders 1`] = `
639639
onFocus={[Function]}
640640
>
641641
<EuiComboBox
642+
async={false}
642643
compressed={false}
643644
fullWidth={false}
644645
id="detectorId"
@@ -666,7 +667,6 @@ exports[`AnomalyDetectors renders 1`] = `
666667
<EuiComboBoxInput
667668
autoSizeInputRef={[Function]}
668669
compressed={false}
669-
focusedOptionId={null}
670670
fullWidth={false}
671671
hasSelectedOptions={false}
672672
id="detectorId"
@@ -717,16 +717,15 @@ exports[`AnomalyDetectors renders 1`] = `
717717
className="euiComboBox__inputWrap euiComboBox__inputWrap--noWrap"
718718
data-test-subj="comboBoxInput"
719719
onClick={[Function]}
720-
tabIndex="-1"
720+
tabIndex={-1}
721721
>
722722
<p
723723
className="euiComboBoxPlaceholder"
724724
>
725725
Select a detector
726726
</p>
727727
<AutosizeInput
728-
aria-activedescendant={null}
729-
aria-controls={null}
728+
aria-controls=""
730729
className="euiComboBox__input"
731730
data-test-subj="comboBoxSearchInput"
732731
id="detectorId"
@@ -754,8 +753,7 @@ exports[`AnomalyDetectors renders 1`] = `
754753
}
755754
>
756755
<input
757-
aria-activedescendant={null}
758-
aria-controls={null}
756+
aria-controls=""
759757
data-test-subj="comboBoxSearchInput"
760758
id="detectorId"
761759
onBlur={[Function]}

public/pages/CreateMonitor/containers/MonitorIndex/__snapshots__/MonitorIndex.test.js.snap

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,6 @@ exports[`MonitorIndex renders 1`] = `
664664
<EuiComboBoxInput
665665
autoSizeInputRef={[Function]}
666666
compressed={false}
667-
focusedOptionId={null}
668667
fullWidth={false}
669668
hasSelectedOptions={false}
670669
id="index"
@@ -712,16 +711,15 @@ exports[`MonitorIndex renders 1`] = `
712711
className="euiComboBox__inputWrap euiComboBox__inputWrap-isClearable"
713712
data-test-subj="comboBoxInput"
714713
onClick={[Function]}
715-
tabIndex="-1"
714+
tabIndex={-1}
716715
>
717716
<p
718717
className="euiComboBoxPlaceholder"
719718
>
720719
Select indices
721720
</p>
722721
<AutosizeInput
723-
aria-activedescendant={null}
724-
aria-controls={null}
722+
aria-controls=""
725723
className="euiComboBox__input"
726724
data-test-subj="comboBoxSearchInput"
727725
id="index"
@@ -749,8 +747,7 @@ exports[`MonitorIndex renders 1`] = `
749747
}
750748
>
751749
<input
752-
aria-activedescendant={null}
753-
aria-controls={null}
750+
aria-controls=""
754751
data-test-subj="comboBoxSearchInput"
755752
id="index"
756753
onBlur={[Function]}

public/pages/Monitors/components/AcknowledgeModal/__snapshots__/AcknowledgeModal.test.js.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
exports[`AcknowledgeModal renders 1`] = `
44
<EuiOverlayMask>
55
<EuiConfirmModal
6-
buttonColor="primary"
76
cancelButtonText="cancel"
87
confirmButtonText="Acknowledge"
98
maxWidth={650}

yarn.lock

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
dependencies:
1717
"@babel/highlight" "^7.8.3"
1818

19-
"@babel/core@^7.9.0":
19+
"@babel/core@^7.5.5":
2020
version "7.9.6"
2121
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.9.6.tgz#d9aa1f580abf3b2286ef40b6904d390904c63376"
2222
integrity sha512-nD3deLvbsApbHAHttzIssYqgb883yU/d9roe4RZymBCDaZryMJDbptVpEpeQuRh4BJ+SYI8le9YGxKvFEvl1Wg==
@@ -1151,16 +1151,11 @@ combined-stream@^1.0.6, combined-stream@~1.0.6:
11511151
dependencies:
11521152
delayed-stream "~1.0.0"
11531153

1154-
commander@^2.20.0:
1154+
commander@^2.20.0, commander@^2.9.0:
11551155
version "2.20.3"
11561156
resolved "https://registry.yarnpkg.com/commander/-/commander-2.20.3.tgz#fd485e84c03eb4881c20722ba48035e8531aeb33"
11571157
integrity sha512-GpVkmM8vF2vQUkj2LvZmD35JxeJOLCwJ9cUkugyk2nuhbv3+mJvpLYYt+0+USMxE+oj+ey/lJEnhZw75x/OMcQ==
11581158

1159-
commander@^3.0.0:
1160-
version "3.0.2"
1161-
resolved "https://registry.yarnpkg.com/commander/-/commander-3.0.2.tgz#6837c3fb677ad9933d1cfba42dd14d5117d6b39e"
1162-
integrity sha512-Gar0ASD4BDyKC4hl4DwHqDrmvjoxWKZigVnAbn5H1owvm4CxCPdb0HQDehwNYMJpla5+M2tPmPARzhtYuwpHow==
1163-
11641159
commondir@^1.0.1:
11651160
version "1.0.1"
11661161
resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"

0 commit comments

Comments
 (0)