-
Notifications
You must be signed in to change notification settings - Fork 100
Open
Description
Problem
The on-comment
regex patterns in the autogenerated Tekton pull-request pipeline files contain literal spaces after /kfbuild
which prevents proper matching. Pipelines-as-Code trims leading whitespace from comment text, so patterns like ^/kfbuild jupyter/trustyai/ubi9-python-3.12
will never match actual comments.
Affected Files
Multiple pipeline files in .tekton/
directory with names ending in -pull-request.yaml
have this issue, including:
.tekton/odh-workbench-jupyter-trustyai-cpu-py312-ubi9-pull-request.yaml
- And likely many others with similar patterns
Current Problematic Pattern
pipelinesascode.tekton.dev/on-comment: ^/kfbuild jupyter/trustyai/ubi9-python-3.12
Suggested Fix
pipelinesascode.tekton.dev/on-comment: ^/kfbuild\s+jupyter/trustyai/ubi9-python-3\.12$
Changes Needed
- Replace literal spaces with
\s+
after/kfbuild
- Escape dots in version numbers (e.g.,
3\.12
) - Add end-of-line anchor
$
for precise matching - Update the generation script
scripts/generate_pull_request_pipelineruns.py
to produce correct patterns
Context
- Identified in PR RHOAIENG-30439: tekton: add script to generate pull-request-specific
PipelineRun
definitions #1508: RHOAIENG-30439: tekton: add script to generate pull-request-specificPipelineRun
definitions #1508 - Original comment: RHOAIENG-30439: tekton: add script to generate pull-request-specific
PipelineRun
definitions #1508 (comment)
Impact
Currently, the comment-triggered builds cannot be activated because the regex patterns don't match actual user comments.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
📋 Backlog