-
Notifications
You must be signed in to change notification settings - Fork 100
Open
Description
Problem Description
Multiple imagestream files in the repository contain a doubled slash (//
) in the opendatahub.io/runtime-image-url
annotation, resulting in malformed URLs.
Current Issue
The annotation currently shows:
opendatahub.io/runtime-image-url: "https://github.com//opendatahub-io/notebooks/tree/main/runtimes"
Expected Fix
Should be:
opendatahub.io/runtime-image-url: "https://github.com/opendatahub-io/notebooks/tree/main/runtimes"
Affected Files (11 total)
Base manifests:
- manifests/base/runtime-datascience-imagestream.yaml
- manifests/base/runtime-minimal-imagestream.yaml
- manifests/base/runtime-pytorch-imagestream.yaml
- manifests/base/runtime-rocm-pytorch-imagestream.yaml
- manifests/base/runtime-rocm-tensorflow-imagestream.yaml
- manifests/base/runtime-tensorflow-imagestream.yaml
Overlay manifests:
- manifests/overlays/additional/runtime-datascience-imagestream-beta.yaml
- manifests/overlays/additional/runtime-minimal-imagestream-beta.yaml
- manifests/overlays/additional/runtime-pytorch-imagestream-beta.yaml
- manifests/overlays/additional/runtime-rocm-pytorch-imagestream-beta.yaml
- manifests/overlays/additional/runtime-tensorflow-imagestream-beta.yaml
Implementation
# Fix all occurrences with a simple sed command
sed -i 's|github.com//opendatahub-io|github.com/opendatahub-io|g' manifests/base/runtime-*-imagestream.yaml manifests/overlays/additional/runtime-*-imagestream-beta.yaml
Context
This issue was identified during PR #1401 review but is considered separate from the naming standardization work in that PR.
Acceptance Criteria
- All 11 imagestream files have correctly formatted runtime-image-url annotations
- No doubled slashes remain in any URL annotations
- Changes are tested to ensure no regression in functionality
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
📋 Backlog