forked from kubeflow/kubeflow
-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Description
Problem
During the analysis of PR #650 (removing ACK_GINKGO_DEPRECATIONS), a Python deprecation warning was discovered in the logs:
/opt/app-root/lib/python3.6/site-packages/jupyter_server_mathjax/app.py:40: FutureWarning: The alias '_()' will be deprecated. Use '_i18n()' instead.
This warning originated from the quay.io/thoth-station/s2i-minimal-notebook
images used in various test configurations throughout this repository.
Current State
The repository currently uses quay.io/thoth-station/s2i-minimal-notebook
images in multiple locations for testing purposes. These images appear to contain outdated dependencies that generate deprecation warnings.
Proposed Solution
We should:
- Audit current image usage: Identify all locations where
quay.io/thoth-station/s2i-minimal-notebook
images are used - Evaluate alternatives: Research more recent and actively maintained notebook images suitable for testing
- Update test configurations: Replace outdated images with newer, maintained alternatives
- Establish maintenance strategy: Create a process for keeping test images up-to-date in the future
Benefits
- Eliminate deprecation warnings in test logs
- Ensure tests run with current dependencies
- Improve test reliability and maintainability
- Reduce noise in CI logs that could mask real issues
References
- Related PR: remove ACK_GINKGO_DEPRECATIONS=1.16.5 env var in make test #650 (remove ACK_GINKGO_DEPRECATIONS=1.16.5 env var in make test)
- Discussion: remove ACK_GINKGO_DEPRECATIONS=1.16.5 env var in make test #650 (comment)
Acceptance Criteria
- Identify all usages of
quay.io/thoth-station/s2i-minimal-notebook
images - Research and select appropriate replacement images
- Update test configurations to use new images
- Verify all tests pass with new images
- Document image selection rationale and maintenance process
Metadata
Metadata
Assignees
Labels
No labels