Skip to content

Commit 763942f

Browse files
committed
Merge pull request #2928 from alalek:cmake_handle_glog_target
2 parents 18823d8 + 11cda6f commit 763942f

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

modules/sfm/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,15 @@ endif()
2727
if(NOT DEFINED GFLAGS_INCLUDE_DIRS AND DEFINED GFLAGS_INCLUDE_DIR)
2828
set(GFLAGS_INCLUDE_DIRS "${GFLAGS_INCLUDE_DIR}")
2929
endif()
30+
if(NOT GFLAGS_LIBRARIES AND TARGET gflags::gflags)
31+
set(GFLAGS_LIBRARIES gflags::gflags)
32+
endif()
3033
if(NOT DEFINED GLOG_INCLUDE_DIRS AND DEFINED GLOG_INCLUDE_DIR)
3134
set(GLOG_INCLUDE_DIRS "${GLOG_INCLUDE_DIR}")
3235
endif()
36+
if(NOT GLOG_LIBRARIES AND TARGET glog::glog)
37+
set(GLOG_LIBRARIES glog::glog)
38+
endif()
3339

3440
if((gflags_FOUND OR Gflags_FOUND OR GFLAGS_FOUND OR GFLAGS_INCLUDE_DIRS) AND (glog_FOUND OR Glog_FOUND OR GLOG_FOUND OR GLOG_INCLUDE_DIRS))
3541
set(__cache_key "${GLOG_INCLUDE_DIRS} ~ ${GFLAGS_INCLUDE_DIRS} ~ ${GLOG_LIBRARIES} ~ ${GFLAGS_LIBRARIES}")

modules/sfm/src/libmv_light/libmv/correspondence/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ FILE(GLOB CORRESPONDENCE_HDRS *.h)
88

99
ADD_LIBRARY(correspondence STATIC ${CORRESPONDENCE_SRC} ${CORRESPONDENCE_HDRS})
1010

11-
TARGET_LINK_LIBRARIES(correspondence LINK_PRIVATE ${GLOG_LIBRARY} multiview)
11+
TARGET_LINK_LIBRARIES(correspondence LINK_PRIVATE ${GLOG_LIBRARIES} multiview)
1212
IF(TARGET Eigen3::Eigen)
1313
TARGET_LINK_LIBRARIES(correspondence LINK_PUBLIC Eigen3::Eigen)
1414
ENDIF()

modules/sfm/src/libmv_light/libmv/multiview/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ SET(MULTIVIEW_SRC conditioning.cc
1717
FILE(GLOB MULTIVIEW_HDRS *.h)
1818

1919
ADD_LIBRARY(multiview STATIC ${MULTIVIEW_SRC} ${MULTIVIEW_HDRS})
20-
TARGET_LINK_LIBRARIES(multiview LINK_PRIVATE ${GLOG_LIBRARY} numeric)
20+
TARGET_LINK_LIBRARIES(multiview LINK_PRIVATE ${GLOG_LIBRARIES} numeric)
2121
IF(TARGET Eigen3::Eigen)
2222
TARGET_LINK_LIBRARIES(multiview LINK_PUBLIC Eigen3::Eigen)
2323
ENDIF()

0 commit comments

Comments
 (0)