Skip to content

Commit 5a35eb1

Browse files
authored
Merge pull request #3423 from matijazigic:fix_optflow_rlof
### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake The bug has already been reported and explained on the OpenCV forum: - [optflow-calcopticalflowsparserlof-giving-assertion-error](https://forum.opencv.org/t/cv2-optflow-calcopticalflowsparserlof-giving-assertion-error/4835) - [calcopticalflowsparserlof-assertion-error-in-initialflow](https://forum.opencv.org/t/calcopticalflowsparserlof-assertion-error-in-initialflow/8669) The bug is manifested only if 'UseInitialFlow' is set to true and 'ForwardBackwardThreshold' > 0 (enabled).
1 parent 592b376 commit 5a35eb1

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

modules/optflow/src/rlofflow.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,8 +408,13 @@ class SparseRLOFOpticalFlowImpl : public SparseRLOFOpticalFlow
408408
cv::Mat(1,npoints , CV_32FC2, &nextPoints[0]).copyTo(nextPtsMat);
409409
if (forwardBackwardThreshold > 0)
410410
{
411+
// use temp variable to properly initialize refPoints
412+
// inside 'calcLocalOpticalFlow' when 'use_init_flow' and 'fwd_bwd_thresh' parameters are used
413+
bool temp_param = param->getUseInitialFlow();
414+
param->setUseInitialFlow(false);
411415
// reuse image pyramids
412416
calcLocalOpticalFlow(nextImage, prevImage, currPyramid, prevPyramid, nextPoints, refPoints, *(param.get()));
417+
param->setUseInitialFlow(temp_param);
413418
}
414419
for (unsigned int r = 0; r < refPoints.size(); r++)
415420
{

0 commit comments

Comments
 (0)