Skip to content

Commit e3b234c

Browse files
committed
Properly close db connection
1 parent 63c728e commit e3b234c

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/main/java/eu/openanalytics/containerproxy/stat/impl/JDBCCollector.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,14 @@ public JDBCCollector(Environment environment) {
100100
@Override
101101
public void accept(Event event, Environment env) throws IOException {
102102
String sql = "INSERT INTO event(event_time, username, type, data) VALUES (?,?,?,?)";
103-
try (PreparedStatement stmt = ds.getConnection().prepareStatement(sql)) {
104-
stmt.setTimestamp(1, new Timestamp(System.currentTimeMillis()));
105-
stmt.setString(2, event.user);
106-
stmt.setString(3, event.type);
107-
stmt.setString(4, event.data);
108-
stmt.executeUpdate();
103+
try (Connection con = ds.getConnection()) {
104+
try (PreparedStatement stmt = con.prepareStatement(sql)) {
105+
stmt.setTimestamp(1, new Timestamp(System.currentTimeMillis()));
106+
stmt.setString(2, event.user);
107+
stmt.setString(3, event.type);
108+
stmt.setString(4, event.data);
109+
stmt.executeUpdate();
110+
}
109111
} catch (SQLException e) {
110112
throw new IOException("Exception while loggin stats", e);
111113
}

0 commit comments

Comments
 (0)