Skip to content

Commit 93ed0b0

Browse files
committed
Merge branch 'hotfix/0.8.9'
2 parents b55e80a + be097f8 commit 93ed0b0

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>eu.openanalytics</groupId>
77
<artifactId>containerproxy</artifactId>
8-
<version>0.8.8</version>
8+
<version>0.8.9</version>
99
<name>ContainerProxy</name>
1010
<packaging>jar</packaging>
1111

src/main/java/eu/openanalytics/containerproxy/auth/impl/KeycloakAuthenticationBackend.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
package eu.openanalytics.containerproxy.auth.impl;
2222

2323
import java.io.Serializable;
24+
import java.util.Arrays;
2425
import java.util.Collection;
2526
import java.util.HashMap;
2627
import java.util.List;
@@ -65,6 +66,8 @@
6566
import org.springframework.security.core.session.SessionRegistryImpl;
6667
import org.springframework.security.web.AuthenticationEntryPoint;
6768
import org.springframework.security.web.authentication.logout.LogoutFilter;
69+
import org.springframework.security.web.authentication.session.ChangeSessionIdAuthenticationStrategy;
70+
import org.springframework.security.web.authentication.session.CompositeSessionAuthenticationStrategy;
6871
import org.springframework.security.web.authentication.session.RegisterSessionAuthenticationStrategy;
6972
import org.springframework.security.web.authentication.session.SessionAuthenticationStrategy;
7073
import org.springframework.security.web.authentication.www.BasicAuthenticationFilter;
@@ -169,7 +172,10 @@ protected HttpSessionManager httpSessionManager() {
169172
@Bean
170173
@ConditionalOnProperty(name="proxy.authentication", havingValue="keycloak")
171174
protected SessionAuthenticationStrategy sessionAuthenticationStrategy() {
172-
return new RegisterSessionAuthenticationStrategy(new SessionRegistryImpl());
175+
return new CompositeSessionAuthenticationStrategy(Arrays.asList(
176+
new RegisterSessionAuthenticationStrategy(new SessionRegistryImpl()),
177+
new ChangeSessionIdAuthenticationStrategy()
178+
));
173179
}
174180

175181
@Bean

src/main/java/eu/openanalytics/containerproxy/auth/impl/saml/SAMLConfiguration.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
import org.springframework.security.web.authentication.logout.LogoutHandler;
7070
import org.springframework.security.web.authentication.logout.SecurityContextLogoutHandler;
7171
import org.springframework.security.web.authentication.logout.SimpleUrlLogoutSuccessHandler;
72+
import org.springframework.security.web.authentication.session.ChangeSessionIdAuthenticationStrategy;
7273
import org.springframework.security.web.util.matcher.AntPathRequestMatcher;
7374

7475
import javax.inject.Inject;
@@ -324,6 +325,7 @@ public SAMLProcessingFilter samlWebSSOProcessingFilter() throws Exception {
324325
samlWebSSOProcessingFilter.setAuthenticationManager(authenticationManager);
325326
samlWebSSOProcessingFilter.setAuthenticationSuccessHandler(successRedirectHandler());
326327
samlWebSSOProcessingFilter.setAuthenticationFailureHandler(authenticationFailureHandler());
328+
samlWebSSOProcessingFilter.setSessionAuthenticationStrategy(new ChangeSessionIdAuthenticationStrategy());
327329
return samlWebSSOProcessingFilter;
328330
}
329331

0 commit comments

Comments
 (0)