fix: do now throw when panel does not exist (#116)

web-padawan · web-flow · commit 8007daf83fde · 2021-12-06T15:59:00.000+02:00
diff --git a/src/api-viewer-tabs.ts b/src/api-viewer-tabs.ts
@@ -179,11 +179,10 @@ export class ApiViewerTabs extends LitElement {
     this.reset();
 
     const newPanel = this._panelForTab(newTab);
-    if (!newPanel) {
-      throw new Error('No panel with for tab');
+    if (newPanel) {
+      newTab.selected = true;
+      newPanel.hidden = false;
     }
-    newTab.selected = true;
-    newPanel.hidden = false;
   }
 
   private _onKeyDown(event: KeyboardEvent): void {

Original file line number	Diff line number	Diff line change
`@@ -179,11 +179,10 @@ export class ApiViewerTabs extends LitElement {`
`179`	`179`	`this.reset();`
`180`	`180`
`181`	`181`	`const newPanel = this._panelForTab(newTab);`
`182`		`- if (!newPanel) {`
`183`		`- throw new Error('No panel with for tab');`
	`182`	`+ if (newPanel) {`
	`183`	`+ newTab.selected = true;`
	`184`	`+ newPanel.hidden = false;`
`184`	`185`	`}`
`185`		`- newTab.selected = true;`
`186`		`- newPanel.hidden = false;`
`187`	`186`	`}`
`188`	`187`
`189`	`188`	`private _onKeyDown(event: KeyboardEvent): void {`