Skip to content

Commit 815e387

Browse files
ymgytcijothomas
andauthored
Use semantic conventions in examples (#1639)
Co-authored-by: Cijo Thomas <cijo.thomas@gmail.com>
1 parent 9fe943d commit 815e387

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

examples/logs-basic/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@ opentelemetry = { path = "../../opentelemetry", features = ["logs"] }
1010
opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["logs"] }
1111
opentelemetry-stdout = { path = "../../opentelemetry-stdout", features = ["logs"]}
1212
opentelemetry-appender-log = { path = "../../opentelemetry-appender-log", default-features = false}
13+
opentelemetry-semantic-conventions = { path = "../../opentelemetry-semantic-conventions" }
1314
log = { workspace = true }
1415
serde_json = { workspace = true }

examples/logs-basic/src/main.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ use opentelemetry::KeyValue;
33
use opentelemetry_appender_log::OpenTelemetryLogBridge;
44
use opentelemetry_sdk::logs::{Config, LoggerProvider};
55
use opentelemetry_sdk::Resource;
6+
use opentelemetry_semantic_conventions::resource::SERVICE_NAME;
67

78
fn main() {
89
// Setup LoggerProvider with a stdout exporter
@@ -14,7 +15,7 @@ fn main() {
1415
let logger_provider = LoggerProvider::builder()
1516
.with_config(
1617
Config::default().with_resource(Resource::new(vec![KeyValue::new(
17-
"service.name",
18+
SERVICE_NAME,
1819
"logs-basic-example",
1920
)])),
2021
)

examples/tracing-jaeger/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ publish = false
99
opentelemetry = { path = "../../opentelemetry" }
1010
opentelemetry_sdk = { path = "../../opentelemetry-sdk", features = ["rt-tokio"] }
1111
opentelemetry-otlp = { path = "../../opentelemetry-otlp", features = ["tonic"] }
12+
opentelemetry-semantic-conventions = { path = "../../opentelemetry-semantic-conventions" }
1213
tokio = { workspace = true, features = ["full"] }

examples/tracing-jaeger/src/main.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ use opentelemetry::{
66
};
77
use opentelemetry_otlp::WithExportConfig;
88
use opentelemetry_sdk::{runtime, trace as sdktrace, Resource};
9+
use opentelemetry_semantic_conventions::resource::SERVICE_NAME;
10+
911
use std::error::Error;
1012

1113
fn init_tracer() -> Result<opentelemetry_sdk::trace::Tracer, TraceError> {
@@ -18,7 +20,7 @@ fn init_tracer() -> Result<opentelemetry_sdk::trace::Tracer, TraceError> {
1820
)
1921
.with_trace_config(
2022
sdktrace::config().with_resource(Resource::new(vec![KeyValue::new(
21-
"service.name",
23+
SERVICE_NAME,
2224
"tracing-jaeger",
2325
)])),
2426
)

0 commit comments

Comments
 (0)