|
113 | 113 | use log::{Level, Metadata, Record};
|
114 | 114 | use opentelemetry::{
|
115 | 115 | logs::{AnyValue, LogRecord, Logger, LoggerProvider, Severity},
|
116 |
| - InstrumentationScope, Key, |
| 116 | + Key, |
117 | 117 | };
|
118 | 118 | #[cfg(feature = "experimental_metadata_attributes")]
|
119 | 119 | use opentelemetry_semantic_conventions::attribute::{
|
@@ -189,12 +189,13 @@ where
|
189 | 189 | L: Logger + Send + Sync,
|
190 | 190 | {
|
191 | 191 | pub fn new(provider: &P) -> Self {
|
192 |
| - let scope = InstrumentationScope::builder("opentelemetry-log-appender") |
193 |
| - .with_version(env!("CARGO_PKG_VERSION")) |
194 |
| - .build(); |
195 |
| - |
196 |
| - OpenTelemetryLogBridge { |
197 |
| - logger: provider.logger_with_scope(scope), |
| 192 | + Self { |
| 193 | + // Using empty scope name. |
| 194 | + // The name/version of this library itself can be added |
| 195 | + // as a Scope attribute once a semantic convention is |
| 196 | + // defined for the same. |
| 197 | + // See https://github.com/open-telemetry/semantic-conventions/issues/1550 |
| 198 | + logger: provider.logger(""), |
198 | 199 | _phantom: Default::default(),
|
199 | 200 | }
|
200 | 201 | }
|
@@ -985,9 +986,13 @@ mod tests {
|
985 | 986 | );
|
986 | 987 |
|
987 | 988 | let logs = exporter.get_emitted_logs().unwrap();
|
| 989 | + assert_eq!(logs.len(), 1); |
| 990 | + |
| 991 | + let log = logs.first().unwrap(); |
| 992 | + assert_eq!(log.instrumentation.name(), ""); |
988 | 993 |
|
989 | 994 | let get = |needle: &str| -> Option<AnyValue> {
|
990 |
| - logs[0].record.attributes_iter().find_map(|(k, v)| { |
| 995 | + log.record.attributes_iter().find_map(|(k, v)| { |
991 | 996 | if k.as_str() == needle {
|
992 | 997 | Some(v.clone())
|
993 | 998 | } else {
|
@@ -1197,9 +1202,13 @@ mod tests {
|
1197 | 1202 | );
|
1198 | 1203 |
|
1199 | 1204 | let logs = exporter.get_emitted_logs().unwrap();
|
| 1205 | + assert_eq!(logs.len(), 1); |
| 1206 | + |
| 1207 | + let log = logs.first().unwrap(); |
| 1208 | + assert_eq!(log.instrumentation.name(), ""); |
1200 | 1209 |
|
1201 | 1210 | let get = |needle: &str| -> Option<AnyValue> {
|
1202 |
| - logs[0].record.attributes_iter().find_map(|(k, v)| { |
| 1211 | + log.record.attributes_iter().find_map(|(k, v)| { |
1203 | 1212 | if k.as_str() == needle {
|
1204 | 1213 | Some(v.clone())
|
1205 | 1214 | } else {
|
|
0 commit comments