Skip to content

Commit 3106109

Browse files
authored
chore(nodejs): change from loggerProvider.addLogRecordProcessor() to 'processors' constructor arg (#1903)
* chore(nodejs): change from loggerProvider.addLogRecordProcessor() to 'processors' constructor arg This will fix the CI failure in #1897. `@opentelemetry/sdk-logs@0.203.0` *dropped* the deprecated `LoggerProvider#addLogRecordProcessor(...)` method. Refs: open-telemetry/opentelemetry-js#5764 * lint:fix
1 parent a5cefc8 commit 3106109

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

nodejs/packages/layer/src/wrapper.ts

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ import {
4646
} from '@opentelemetry/instrumentation-aws-lambda';
4747
import { AWSXRayPropagator } from '@opentelemetry/propagator-aws-xray';
4848
import { AWSXRayLambdaPropagator } from '@opentelemetry/propagator-aws-xray-lambda';
49+
import { LogRecordProcessor } from '@opentelemetry/sdk-logs';
4950

5051
const defaultInstrumentationList = [
5152
'dns',
@@ -503,25 +504,26 @@ async function initializeLoggerProvider(
503504
);
504505

505506
const logExporter = new OTLPLogExporter();
507+
const logRecordProcessors: LogRecordProcessor[] = [];
506508
const loggerConfig = {
507509
resource,
510+
processors: logRecordProcessors,
508511
};
509-
const loggerProvider = new LoggerProvider(loggerConfig);
510-
if (typeof configureLoggerProvider === 'function') {
511-
configureLoggerProvider(loggerProvider);
512-
} else {
513-
loggerProvider.addLogRecordProcessor(
514-
new BatchLogRecordProcessor(logExporter),
515-
);
516-
logs.setGlobalLoggerProvider(loggerProvider);
512+
if (typeof configureLoggerProvider !== 'function') {
513+
logRecordProcessors.push(new BatchLogRecordProcessor(logExporter));
517514
}
518-
519515
// Logging for debug
520516
if (logLevel === DiagLogLevel.DEBUG) {
521-
loggerProvider.addLogRecordProcessor(
517+
logRecordProcessors.push(
522518
new SimpleLogRecordProcessor(new ConsoleLogRecordExporter()),
523519
);
524520
}
521+
const loggerProvider = new LoggerProvider(loggerConfig);
522+
if (typeof configureLoggerProvider === 'function') {
523+
configureLoggerProvider(loggerProvider);
524+
} else {
525+
logs.setGlobalLoggerProvider(loggerProvider);
526+
}
525527

526528
logsDisableFunction = () => {
527529
logs.disable();

0 commit comments

Comments
 (0)