HttpURLConnection instrumentation doesn't close spans for a lot of scenarios

[surbhiia]

Had a question on HttpURLConnection instrumentation - The instrumentation here does not close spans unless an exception occurs or getInputStream is called. It seems to miss a lot of other scenarios like for example:

//Example 1: No exception occurs and getInputStream is not called
URL url = new URL("http://example.com/”);
URLConnection urlConnection = url.openConnection();
Map<String, List> map = urlConnection.getHeaderFields();
// Or any other similar api’s other than getInputStream that read from connection are called

//Example 2: Post scenario
URL url = new URL("http://example/.com”);
URLConnection urlConnection = url.openConnection();
urlConnection.setDoOutput(true);
OutputStreamWriter out = new OutputStreamWriter(urlConnection.getOutputStream());
out.write("Output test content");
out.close()

Am I wrong in my understanding Or was it discussed before that this was not meant to cover all such possible scenarios?

I found a similar issue that touched this before here but my concern is more from having a complete instrumentation (that covers all possible general scenarios) perspective.

[trask]

hi @surbhiia! IIRC getInputStream() gets called internally by other HttpURLConnection methods. Have you tested the above examples using the Java agent?

[surbhiia]

I haven't tested this yet. But from my understanding getInputStream is only called internally from getResponseCode API. And also from getResponseMessage which calls getResponseCode.

But it could be the case that not visible to us (intrinsically) all apis are calling getInputStream somewhere! I will test if above scenarios create spans and get back to you.

[breedx-splk]

Related: open-telemetry/opentelemetry-android#133 (comment)