Make @WithSpan apply to Class level.

[bmistry13]

@WithSpan annotation is only applied to METHOD. Can we change behavior to apply to Class so ALL methods will get instrumented it is very annoying to add for each method?

[iNikem]

Do you really mean ALL methods or all public methods? What about inherited methods?

[bmistry13]

I mean all public methods from the current class. If you want inherited methods as well @WithSpan(inherited=true) or something similar.

Follow similar to Spring Transactional

[bmistry13]

@iNikem , I tried the @WithSpan method level but agent 0.14 does not pick a method at all. I am in spring boot application and I have Interface A and Concrete Implementation class but Agent does not seem to pick @WithSpan and does not create span. Is there anything I need to do besides annotation?

[trask]

hi @bmistry13, did you put the annotation on the interface method or concrete method? If you put it on the interface method previously, does it work if you move it to the concrete method?

[bmistry13]

@trask , I put it on Concrete Implementation but Spring beans may do a Dynamic PROXY pattern and still NOT showing. Is there anything I need to do? Please let me know.

[trask]

hey @bmistry13 can you create a small repro and open an issue for this?

[bmistry13]

I will try to reproduce it in a simple standalone spring-boot app.

[sp710419]

I have 2 springboot applications instrumented with otel javaagent library. with auto instrumentation everything works fine. Springboot A calls SB B. and B intern makes some internal DB calls. All spans and traces I could see in my jaeger backend. Now I want to inject a custom attribute to the existing trace.

@RestController
public class AppAController {
    
    @Autowired
    private RestTemplate restTemplate;

    @RequestMapping("/test-tracing")
    @WithSpan
    public String entryPointController()  {
        HttpHeaders headers = new HttpHeaders();
        headers.setAccept(Arrays.asList(MediaType.APPLICATION_JSON));
        HttpEntity<String> entity = new HttpEntity<>(headers);
       
        // Here I am calling SB2, second mS endpoint 
        String response=restTemplate.exchange("http://opentelemetryappb:9082/service", HttpMethod.GET, entity, String.class).getBody();

        return "Response from opentelemetry-app-b => : "+response;
    }

As per the above discussion, I just added @WIthSpan to this controller mehod. I understand I have to write some code to create a custom span here using OTEL library. Can some one pls help here how do I inject custom attributes to the existing spans here ? Any reference project/code ??

My springboot using embedded tomcat..

[sp710419]

Thank you. Yes, earlier I tried following your reference project and used a DemoSpanProcessor .
here was my sample code.
..
@autoservice(DemoSpanProcessor.class)
public class DemoSpanProcessor implements SpanProcessor {

@WithSpan
@Override
public void onStart(Context parentContext, ReadWriteSpan span) {
    Baggage.fromContext(parentContext).forEach((s, baggageEntry) -> span.setAttribute(s, baggageEntry.getValue()));
}

....

@autoservice(SdkTracerProviderConfigurer.class)
public class DemoSdkTracerProviderConfigurer implements SdkTracerProviderConfigurer {
@OverRide
public void configure(SdkTracerProviderBuilder tracerProvider, ConfigProperties config) {
tracerProvider
.addSpanProcessor(new DemoSpanProcessor());
}
}
.......

Then I wrote a interceptor for my entrypoint mS and injected the custom attribute..

@component
public class ApplicationInterceptor implements HandlerInterceptor {

@Override
public void postHandle(
        HttpServletRequest request,
        HttpServletResponse response,
        Object handler,
        ModelAndView modelAndView) {

        OpenTelemetry otel = GlobalOpenTelemetry.get();
        Tracer tracer = otel.getTracerProvider().get("opentelemetry-aap-a");
        Baggage.current().toBuilder().put("transactionId","123456");
}

}
...
..

This approach also did not work.
Sorry I am new to OTEL..Not sure If I am doing something wrong..

TIA..

[mateuszrzeszutek]

Baggage.current().toBuilder().put("transactionId","123456");

Baggage is immutable - you have to start (and close) a new scope every time you want to change that. For example:

Baggage newBaggage = Baggage.current().toBuilder().put("transactionId","123456");
try (Scope scope = newBaggage.makeCurrent()) {
  // ... code that calls downstream services
}

[sp710419]

Thank you @mateuszrzeszutek , Appricate your time and responses..

Tried what you suggested and still did not work.

@RequestMapping("/test-tracing")
public String entryPointController() {
     ...
    String response = null;
    Baggage newBaggage = Baggage.current().toBuilder().put("transId","12345678").build();
    try (Scope scope = newBaggage.makeCurrent()) {
        
        //calling another mS
        response=restTemplate.exchange("http://opentelemetryappb:9082/service", HttpMethod.GET, entity, String.class).getBody();
    }
    return "Response from opentelemetry-app-b => : "+response;
}

I still do not see this custom attribute in my traces..
Do I need to add any other jar along with javaagent ? Right now, I have only auto agent added to my classpath in Dockerfile

-Dapplication.name=opentelemetry-app-a -javaagent:/opentelemetry-javaagent-all.jar -jar

TIA again !!

[mateuszrzeszutek]

Hmm, did you put the custom SpanProcessor directly into your application code? Unfortunately that's currently not supported by the agent - you have to build a separate extension jar that'll contain the SpanProcessor and SdkTracerProviderConfigurer implementations. Please take a look at the extension page - you can just copy the project and modify it so that it suits your needs.

[sp710419]

Thanks @mateuszrzeszutek !! It worked.

[MrNocTV]

Hi guys, is this feature implemented?
I want to collect metrics info of my applications. However the default metrics is not enough. I want to apply @WithSpan on all methods and classes in my application. Is this possible?

[mateuszrzeszutek]

Hey @MrNocTV ,
No, it hasn't been implemented yet. @iNikem's comment mentions one problem/caveat with that, but there's a lot more really: should we instrument public methods? what about protected, private ones? what about inherited methods? private methods in the parent class? (also see #2574, since it's somewhat similar)
This feature is quite complex, and there's no "natural" answer to the questions above, it varies case by case.