should kafka instrumentation support mq.broker attribute?

[huange7]

The same attribute has appeared in RocketMQ, for example, messaging.rocketmq.broker_address. As far as I understand, Kafka also has broker address, and so do RabbitMQ and ActiveMQ. Should we create an AttributesGetter to support this attribute?

[laurit]

https://github.com/open-telemetry/semantic-conventions/blob/main/docs/messaging/messaging-spans.md suggests that server.address should be used for the broker.

[huange7]

Thank you for your sharing, but I noticed that the Kafka instrumentation does not inject server.address. What is the reason for not considering it?

[laurit]

In instrumentation code all the useful information is not readily available, perhaps getting the value for server.address is hard and nobody has implemented it.

[huange7]

I understand now. May I convert this into an issue?

[laurit]

There already is #10647

[huange7]

oh, thanks!