Skip to content

Flatten the bridge/opentracing/internal package into bridge/opentracing #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 tasks
MrAlias opened this issue Mar 27, 2025 · 1 comment · May be fixed by #6574
Open
4 tasks

Flatten the bridge/opentracing/internal package into bridge/opentracing #6563

MrAlias opened this issue Mar 27, 2025 · 1 comment · May be fixed by #6574
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:bridges Related to a bridge package
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 27, 2025

This package only contains mocks for testing. These are only ever used in the opentracing bridge.

  • Copy bridge/opentracing/internal/mock.go to bridge/opentracing/mock_test.go
  • Rename all exported types in bridge/opentracing/mock.go to be unexported:
    • ComponentKey -> componentKey
    • ServiceKey -> serviceKey
    • StatusCodeKey -> statusCodeKey
    • StatusMessageKey -> statusMessageKey
    • ErrorKey -> errorKey
    • NameKey -> nameKey
    • MockContextKeyValue -> mockContextKeyValue
    • MockTracer -> mockTracer
    • NewMockTracer -> newMockTracer
    • MockEvent -> mockEvent
    • MockLink -> mockLink
    • MockSpan -> mockSpan
  • Update all references in bridge/opentracing to use the locally defined code
  • Remove bridge/opentracing/internal
@MrAlias MrAlias added contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:bridges Related to a bridge package labels Mar 27, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 27, 2025
@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 2, 2025

Assigned to @Leoff00

@MrAlias MrAlias modified the milestones: v1.36.0, Subsequent v1.36.0 May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers pkg:bridges Related to a bridge package
Projects
None yet
1 participant