Skip to content

Test logging from a span in the opentracing bridge #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrAlias opened this issue Mar 27, 2025 · 2 comments
Open

Test logging from a span in the opentracing bridge #6549

MrAlias opened this issue Mar 27, 2025 · 2 comments
Assignees
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 27, 2025

Based on the chaining of how logging works this needs to also fully test the functionality of:

  • LogEvent
  • LogEventWithPayload
  • Log

func (s *bridgeSpan) LogEvent(event string) {
s.LogEventWithPayload(event, nil)
}
func (s *bridgeSpan) LogEventWithPayload(event string, payload interface{}) {
data := ot.LogData{
Event: event,
Payload: payload,
}
s.Log(data)
}
func (s *bridgeSpan) Log(data ot.LogData) {
record := data.ToLogRecord()
s.LogFields(record.Fields...)
}

@MrAlias MrAlias added contribfest Issue good for KubeCon contribfest good first issue Good for newcomers labels Mar 27, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 27, 2025
@tongoss
Copy link
Contributor

tongoss commented Mar 31, 2025

@MrAlias , can I take this one?

@tongoss
Copy link
Contributor

tongoss commented Apr 6, 2025

@MrAlias , I just notice that these 3 functions have been deprecated, so I just want to confirm whether we still want to add testing?

Image

@MrAlias MrAlias modified the milestones: v1.36.0, Subsequent v1.36.0 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest Issue good for KubeCon contribfest good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants