pkg/*: eliminate use of .Append() (#3862)

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

Author: Aneurysm9

pkg/batchperresourceattr/batchperresourceattr.go

@@ -62,7 +62,8 @@ func (bt *batchTraces) ConsumeTraces(ctx context.Context, td pdata.Traces) error
 		}
 
 		// Append ResourceSpan to pdata.Traces for this attribute value.
-		tracesForAttr.ResourceSpans().Append(rs)
+		tgt := tracesForAttr.ResourceSpans().AppendEmpty()
+		rs.CopyTo(tgt)
 	}
 
 	var errs []error
@@ -114,7 +115,8 @@ func (bt *batchMetrics) ConsumeMetrics(ctx context.Context, td pdata.Metrics) er
 		}
 
 		// Append ResourceSpan to pdata.Metrics for this attribute value.
-		metricsForAttr.ResourceMetrics().Append(rm)
+		tgt := metricsForAttr.ResourceMetrics().AppendEmpty()
+		rm.CopyTo(tgt)
 	}
 
 	var errs []error
@@ -166,7 +168,8 @@ func (bt *batchLogs) ConsumeLogs(ctx context.Context, td pdata.Logs) error {
 		}
 
 		// Append ResourceSpan to pdata.Logs for this attribute value.
-		logsForAttr.ResourceLogs().Append(rl)
+		tgt := logsForAttr.ResourceLogs().AppendEmpty()
+		rl.CopyTo(tgt)
 	}
 
 	var errs []error

pkg/batchpersignal/batchpersignal.go

@@ -53,7 +53,8 @@ func SplitTraces(batch pdata.Traces) []pdata.Traces {
 				}
 
 				// there is only one instrumentation library per batch
-				batches[key].InstrumentationLibrarySpans().At(0).Spans().Append(span)
+				tgt := batches[key].InstrumentationLibrarySpans().At(0).Spans().AppendEmpty()
+				span.CopyTo(tgt)
 			}
 		}
 	}
@@ -98,7 +99,8 @@ func SplitLogs(batch pdata.Logs) []pdata.Logs {
 				}
 
 				// there is only one instrumentation library per batch
-				batches[key].InstrumentationLibraryLogs().At(0).Logs().Append(log)
+				tgt := batches[key].InstrumentationLibraryLogs().At(0).Logs().AppendEmpty()
+				log.CopyTo(tgt)
 			}
 		}
 	}