Skip to content

[feat] Disambiguate AERMask angle unit #587

@loft-nicolas-sanchez

Description

@loft-nicolas-sanchez

The AERMask class takes in the azimuth-elevation in degrees (docs), but outputs it in radians (docs)

Similarly, the VisibilityCriterion class takes in the azimuth-elevation in degrees (docs)

Therefore doing visibility_criterion = VisibilityCriterion.from_aer_mask(aer_mask.azimuth_elevation_mask) won't work, which is very misleading

Describe the solution you'd like
We should probably use a map of Angle : Angle so it's not ambiguous at all.
This will be a breaking however.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions