-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Labels
enhancementNew feature or requestNew feature or request
Description
The AERMask class takes in the azimuth-elevation in degrees (docs), but outputs it in radians (docs)
Similarly, the VisibilityCriterion class takes in the azimuth-elevation in degrees (docs)
Therefore doing visibility_criterion = VisibilityCriterion.from_aer_mask(aer_mask.azimuth_elevation_mask) won't work, which is very misleading
Describe the solution you'd like
We should probably use a map of Angle : Angle so it's not ambiguous at all.
This will be a breaking however.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request