fix: dangling references when custom pointing (#530)

* fix: dangling references when custom pointing

* feat: add a test

* feat: add tests

Author: vishwa2710

src/OpenSpaceToolkit/Astrodynamics/Flight/Profile.cpp

@@ -240,8 +240,8 @@ Profile Profile::CustomPointing(
     const trajectory::Orbit& anOrbit, const std::function<Quaternion(const State&)>& anOrientationGenerator
 )
 {
-    // Copy the orientation generator to avoid dangling references.
-    auto dynamicProviderGenerator = [&anOrbit, anOrientationGenerator](const Instant& anInstant) -> Transform
+    // Copy the orbit and orientation generator to avoid dangling references.
+    auto dynamicProviderGenerator = [anOrbit, anOrientationGenerator](const Instant& anInstant) -> Transform
     {
         const State state = anOrbit.getStateAt(anInstant);
 

test/OpenSpaceToolkit/Astrodynamics/Flight/Profile.test.cpp

@@ -1032,6 +1032,19 @@ TEST_F(OpenSpaceToolkit_Astrodynamics_Flight_Profile, CustomPointing)
             EXPECT_TRUE(calculatedState.getAttitude().isNear(expectedState.getAttitude(), Angle::Arcseconds(1e-15)));
         }
     }
+
+    // Regression test for dangling orbit reference when a custom pointing profile
+    {
+        Profile profile = Profile::Undefined();
+        {
+            const Orbit anotherOrbit =
+                Orbit::SunSynchronous(epoch, Length::Kilometers(500.0), Time(6, 0, 0), earthSPtr);
+
+            profile = Profile::CustomPointing(anotherOrbit, alignmentTargetSPtr, clockingTargetSPtr);
+        }
+
+        EXPECT_NO_THROW(profile.getStateAt(epoch));
+    }
 }
 
 class OpenSpaceToolkit_Astrodynamics_Flight_Profile_Parametrized