Skip to content

Commit c9cc2ac

Browse files
fix: remove zero duration access interval padding (#524)
* fix: zero duration access interval bug * refactor: remove unnecessary null interval check --------- Co-authored-by: vishwa shah <vishwa2710@gmail.com>
1 parent f6823e6 commit c9cc2ac

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/OpenSpaceToolkit/Astrodynamics/Access/Generator.cpp

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -403,9 +403,9 @@ Array<Access> Generator::computeAccessesForTrajectoryTarget(
403403
const Array<physics::time::Interval> accessIntervals =
404404
temporalConditionSolver.solve(this->getConditionFunction(anAccessTarget, aToTrajectory), anInterval);
405405

406-
const Trajectory& aFromTrajectory = anAccessTarget.accessTrajectory();
406+
const Trajectory& fromTrajectory = anAccessTarget.accessTrajectory();
407407

408-
return generateAccessesFromIntervals(accessIntervals, anInterval, aFromTrajectory, aToTrajectory);
408+
return generateAccessesFromIntervals(accessIntervals, anInterval, fromTrajectory, aToTrajectory);
409409
}
410410

411411
Array<Array<Access>> Generator::computeAccessesForFixedTargets(
@@ -933,17 +933,9 @@ Access Generator::GenerateAccess(
933933

934934
const Instant acquisitionOfSignal = anAccessInterval.getStart();
935935

936-
ostk::physics::time::Interval accessInterval = anAccessInterval;
937-
938-
if (anAccessInterval.getDuration() == Duration::Zero())
939-
{
940-
accessInterval = physics::time::Interval::Closed(
941-
anAccessInterval.getStart() - Duration::Seconds(60.0), anAccessInterval.getStart() + Duration::Seconds(60.0)
942-
);
943-
}
944-
945936
const Instant timeOfClosestApproach =
946937
Generator::FindTimeOfClosestApproach(anAccessInterval, aFromTrajectory, aToTrajectory, aTolerance);
938+
947939
const Instant lossOfSignal = anAccessInterval.getEnd();
948940

949941
if (!timeOfClosestApproach.isDefined() and type == Access::Type::Complete)

0 commit comments

Comments
 (0)