fix: ground trajectory discontinuities due to finite differencing step size (#553)

vishwa2710 · web-flow · commit 7007551986b9 · 2025-05-14T11:43:06.000-05:00
* fix: finite difference step size

* fix: tests

* chore: style

* fix: test tolerance
diff --git a/include/OpenSpaceToolkit/Astrodynamics/Trajectory.hpp b/include/OpenSpaceToolkit/Astrodynamics/Trajectory.hpp
@@ -268,7 +268,7 @@ class Trajectory
     static Array<State> computeStates(
         const std::function<physics::coordinate::Position(const Instant&)>& aPositionGenerator,
         const Array<Instant>& anInstantArray,
-        const Duration& aStepSize = Duration::Seconds(1e-6)
+        const Duration& aStepSize = Duration::Seconds(1e-2)
     );
 };
 
diff --git a/src/OpenSpaceToolkit/Astrodynamics/Trajectory.cpp b/src/OpenSpaceToolkit/Astrodynamics/Trajectory.cpp
@@ -328,7 +328,7 @@ Array<State> Trajectory::computeStates(
 
         const Velocity currentVelocity = Velocity::MetersPerSecond(velocityCoordinates, currentPosition.accessFrame());
 
-        states.add(State(currentInstant, currentPosition, currentVelocity));
+        states.add(State(currentInstant, currentPosition, currentVelocity).inFrame(Frame::GCRF()));
     }
 
     return states;
diff --git a/test/OpenSpaceToolkit/Astrodynamics/Trajectory.test.cpp b/test/OpenSpaceToolkit/Astrodynamics/Trajectory.test.cpp

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ Array<State> Trajectory::computeStates(`
`328`	`328`
`329`	`329`	`const Velocity currentVelocity = Velocity::MetersPerSecond(velocityCoordinates, currentPosition.accessFrame());`
`330`	`330`
`331`		`- states.add(State(currentInstant, currentPosition, currentVelocity));`
	`331`	`+ states.add(State(currentInstant, currentPosition, currentVelocity).inFrame(Frame::GCRF()));`
`332`	`332`	`}`
`333`	`333`
`334`	`334`	`return states;`