Skip to content

Commit 7a2218e

Browse files
authored
Merge pull request #300 from oslabs-beta/dev
Dev
2 parents 2f2e249 + 06a805a commit 7a2218e

File tree

302 files changed

+37481
-14938
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

302 files changed

+37481
-14938
lines changed

.babelrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"presets": [
3+
"airbnb"
4+
],
5+
"plugins": ["@emotion"]
6+
}

.editorconfig

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# EditorConfig http://EditorConfig.org
2+
3+
# top-most EditorConfig file
4+
root = true
5+
6+
# All files
7+
[*]
8+
charset = utf-8
9+
end_of_line = lf
10+
indent_size = 2
11+
indent_style = space
12+
insert_final_newline = true
13+
trim_trailing_whitespace = true

.eslintrc

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
{
2-
"extends": ["airbnb", "plugin:jest/recommended"],
2+
"extends": [
3+
"airbnb",
4+
"plugin:jest/recommended",
5+
"plugin:@typescript-eslint/eslint-recommended",
6+
"plugin:@typescript-eslint/recommended"],
37
"root": true,
4-
"plugins": ["jest", "react"],
8+
"plugins": ["jest", "react", "react-hooks", "@typescript-eslint"],
59
"rules": {
610
"arrow-parens": [2, "as-needed"],
711
"import/no-unresolved": "off",
8-
"import/extensions": "off"
12+
"import/extensions": "off",
13+
"react-hooks/rules-of-hooks": "error", // Checks rules of Hooks
14+
"react-hooks/exhaustive-deps": "warn", // Checks effect dependencies
15+
"react/jsx-filename-extension": [0],
16+
"linebreak-style": "off"
917
},
1018
"env": {
1119
"es6": true,

.gitignore

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
node_modules
2+
node_modules/
3+
/node_modules
4+
./node_modules
25
.DS_Store
36
src/extension/build/bundles
47
package/reactime-*.tgz
@@ -8,4 +11,8 @@ coverage
811
src/extension/build.zip
912
src/extension/build.crx
1013
src/extension/build.pem
11-
bower_components
14+
bower_components
15+
sandboxes/manual-tests/NextJS/.next
16+
.vscode
17+
src/app/components/Map.tsx
18+
package-lock.json

.gitmodules

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[submodule "tests/manual-tests/recoilTest"]
2+
path = tests/manual-tests/recoilTest
3+
url = https://github.com/kevinfey/recoilTest

.travis.yml

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
1-
services:
2-
- docker
1+
language: node_js
2+
node_js:
3+
- 12
4+
dist: trusty
5+
cache: npm
6+
git:
7+
submodules: false
8+
# branches:
9+
# only:
10+
# - implementtravisci
11+
install:
12+
- npm install
313
script:
4-
- docker-compose up --abort-on-container-exit
14+
- npm run test

.vscode/settings.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"eslint.enable": true,
3+
"git.ignoreLimitWarning": true
4+
}

CONTRIBUTING.md

Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
# Welcome to the Reactime contributing guide!
2+
3+
Thank you for investing your time in contributing to our project! :sparkles:.
4+
5+
In this guide you will get an overview of the contribution workflow from opening an issue, creating a PR, reviewing, and merging the PR.
6+
7+
## New contributor guide
8+
9+
To get an overview of the project, read the [README](README.md). Here are some resources to help you get started with open source contributions:
10+
11+
- [Finding ways to contribute to open source on GitHub](https://docs.github.com/en/get-started/exploring-projects-on-github/finding-ways-to-contribute-to-open-source-on-github)
12+
- [Set up Git](https://docs.github.com/en/get-started/quickstart/set-up-git)
13+
- [GitHub flow](https://docs.github.com/en/get-started/quickstart/github-flow)
14+
- [Collaborating with pull requests](https://docs.github.com/en/github/collaborating-with-pull-requests)
15+
16+
17+
## Getting started
18+
19+
To navigate our codebase with confidence, see the Developer READMEs [Developer Installation](/DeveloperREADME.md) and [Developer Guidelines](/src/README.md) :confetti_ball:.
20+
21+
### Issues
22+
23+
#### Create a new issue
24+
25+
If you spot a problem with the docs, [search if an issue already exists](https://github.com/open-source-labs/reactime/issues). If a related issue doesn't exist, you can open a new issue using a relevant [issue form](https://github.com/open-source-labs/reactime/issues/new).
26+
27+
#### Solve an issue
28+
29+
Scan through our [existing issues](https://github.com/open-source-labs/reactime/issues) to find one that interests you. As a general rule, we don’t assign issues to anyone. If you find an issue to work on, you are welcome to open a PR with a fix.
30+
31+
### Make Changes
32+
33+
#### Make changes in the UI
34+
35+
Click **Make a contribution** at the bottom of any docs page to make small changes such as a typo, sentence fix, or a broken link. This takes you to the `.md` file where you can make your changes and [create a pull request](#pull-request) for a review.
36+
37+
#### Make changes locally
38+
39+
1. [Install Git LFS](https://docs.github.com/en/github/managing-large-files/versioning-large-files/installing-git-large-file-storage).
40+
41+
2. Fork the repository.
42+
- Using GitHub Desktop:
43+
- [Getting started with GitHub Desktop](https://docs.github.com/en/desktop/installing-and-configuring-github-desktop/getting-started-with-github-desktop) will guide you through setting up Desktop.
44+
- Once Desktop is set up, you can use it to [fork the repo](https://github.com/open-source-labs/reactime.git)!
45+
46+
- Using the command line:
47+
- [Fork the repo](https://github.com/open-source-labs/reactime.git) so that you can make your changes without affecting the original project until you're ready to merge them.
48+
49+
3. Create a working branch and start with your changes!
50+
51+
### Commit your update
52+
53+
Commit the changes once you are happy with them.
54+
55+
### Pull Request
56+
57+
When you're finished with the changes, create a pull request, also known as a PR.
58+
- Fill the "Ready for review" template so that we can review your PR. This template helps reviewers understand your changes as well as the purpose of your pull request.
59+
- Don't forget to [link PR to issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) if you are solving one.
60+
- Enable the checkbox to [allow maintainer edits](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork) so the branch can be updated for a merge.
61+
Once you submit your PR, a Docs team member will review your proposal. We may ask questions or request additional information.
62+
- We may ask for changes to be made before a PR can be merged, either using [suggested changes](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request) or pull request comments. You can apply suggested changes directly through the UI. You can make any other changes in your fork, then commit them to your branch.
63+
- As you update your PR and apply changes, mark each conversation as [resolved](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request#resolving-conversations).
64+
- If you run into any merge issues, checkout this [git tutorial](https://github.com/skills/resolve-merge-conflicts) to help you resolve merge conflicts and other issues.
65+
66+
### Your PR is merged!
67+
68+
Congratulations :tada::tada: The Reactime team thanks you! :sparkles:.
69+
70+
Once your PR is merged, your contributions will be publicly visible on [Reactime](https://github.com/open-source-labs/reactime)!

DeveloperREADME.md

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
<div>
2+
<h1>Development Enviroment Setup</h1>
3+
4+
<h2>Getting Started</h2>
5+
6+
1. <a href="https://chrome.google.com/webstore/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi?hl=en">Download React Dev Tools from the Chrome Webstore Here</a>
7+
8+
2. Clone down the Reactime repo onto your machine.
9+
10+
```
11+
git clone https://github.com/open-source-labs/reactime.git
12+
```
13+
14+
3. Install dependencies and build.
15+
16+
```
17+
cd reactime
18+
npm install --force
19+
npm run build
20+
```
21+
<b>With release of Node v18.12.1 (LTS) on 11/4/22, the script has been updated to 'npm run dev' || 'npm run build' for backwards compatibility.<br/>
22+
For version Node v16.16.0, please use script 'npm run devlegacy' || 'npm run buildlegacy'</b>
23+
24+
4. Spin up the demo application.
25+
26+
```
27+
cd demo-app
28+
npm install
29+
npm start
30+
```
31+
32+
5. Add Reactime to your Chrome extensions.
33+
34+
- Navigate to chrome://extensions
35+
- Select “Load Unpacked”
36+
- Choose reactime > src > extension > build
37+
- Navigate to http://localhost:8080/ to inspect the demo application using Reactime!
38+
<br>
39+
40+
<p align="center">
41+
<img src="./assets/reactime-dev-setup.gif" />
42+
</p>
43+
44+
<h2>Documentation for Consideration</h2>
45+
<h4>Can Reactime be integrated with Redux compatibility so applications using Redux can track state in Reactime?</h4>
46+
Yes, but it would be very time-consuming and not the most feasible option while Redux devtools exists already. With how Redux devtools is currently set up, a developer is unable to use Redux devtools as a third-party user and integrate its functionality into their own application, as Redux devtools is meant to be used directly on an application using Redux for state-tracking purposes. Since the devtools do not appear to have a public API for integrated use in an application or it simply does not exist, Redux devtools would need to be rebuilt from the ground up and then integrated into Reactime, or built into Reactime directly still from scratch.

0 commit comments

Comments
 (0)