Merge pull request #11149 from drwootton/spml_ucx_leak

jjhursey · web-flow · commit e4cedad12f7e · 2022-12-06T09:26:44.000-06:00
Fix memory leak in mca_spml_ucx_register: Coverity CID 1498721
diff --git a/oshmem/mca/spml/ucx/spml_ucx.c b/oshmem/mca/spml/ucx/spml_ucx.c
@@ -709,7 +709,7 @@ sshmem_mkey_t *mca_spml_ucx_register(void* addr,
     if (MEMHEAP_SEG_INVALID == segno) {
         SPML_UCX_ERROR("mca_spml_ucx_register failed because of invalid "
             "segment number: %d\n", segno);
-        return NULL;
+        goto error_out;
     }
     mem_seg = memheap_find_seg(segno);
 

Original file line number	Diff line number	Diff line change
`@@ -709,7 +709,7 @@ sshmem_mkey_t mca_spml_ucx_register(void addr,`
`709`	`709`	`if (MEMHEAP_SEG_INVALID == segno) {`
`710`	`710`	`SPML_UCX_ERROR("mca_spml_ucx_register failed because of invalid "`
`711`	`711`	`"segment number: %d\n", segno);`
`712`		`- return NULL;`
	`712`	`+ goto error_out;`
`713`	`713`	`}`
`714`	`714`	`mem_seg = memheap_find_seg(segno);`
`715`	`715`