Skip to content

Commit d65fae1

Browse files
authored
Merge pull request #6693 from hoopoepg/topic/fixed-compilation-warnings
SPML/UCX: fixed few compilation warnings
2 parents 5e0e1b6 + 421a7fd commit d65fae1

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

oshmem/mca/spml/ucx/spml_ucx.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,8 @@ static int mca_spml_ucx_ctx_create_common(long options, mca_spml_ucx_ctx_t **ucx
551551
{
552552
ucp_worker_params_t params;
553553
ucp_ep_params_t ep_params;
554-
size_t i, j, nprocs = oshmem_num_procs();
554+
size_t i, nprocs = oshmem_num_procs();
555+
int j;
555556
ucs_status_t err;
556557
spml_ucx_mkey_t *ucx_mkey;
557558
sshmem_mkey_t *mkey;

oshmem/mca/spml/ucx/spml_ucx.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ static inline void mca_spml_ucx_aux_unlock(void)
184184
}
185185
}
186186

187-
static void mca_spml_ucx_cache_mkey(mca_spml_ucx_ctx_t *ucx_ctx, sshmem_mkey_t *mkey, uint32_t segno, int dst_pe)
187+
static inline void mca_spml_ucx_cache_mkey(mca_spml_ucx_ctx_t *ucx_ctx,
188+
sshmem_mkey_t *mkey, uint32_t segno, int dst_pe)
188189
{
189190
ucp_peer_t *peer;
190191

oshmem/mca/sshmem/ucx/configure.m4

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,10 @@ AC_DEFUN([MCA_oshmem_sshmem_ucx_CONFIG],[
5050
sshmem_ucx_LIBS+=" $alloc_dm_LIBS"
5151
sshmem_ucx_LDFLAGS+=" $alloc_dm_LDFLAGS"
5252
],
53-
[AC_MSG_NOTICE([UCX device memory allocation is not supported])])
53+
[
54+
AC_MSG_NOTICE([UCX device memory allocation is not supported])
55+
AC_DEFINE([HAVE_UCX_DEVICE_MEM], [0], [Support for device memory allocation])
56+
])
5457
AC_LANG_POP([C])
5558
5659
CPPFLAGS="$save_CPPFLAGS"

oshmem/mca/sshmem/ucx/sshmem_ucx_module.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@ segment_create(map_segment_t *ds_buf,
225225
{
226226
mca_spml_ucx_t *spml = (mca_spml_ucx_t*)mca_spml.self;
227227
unsigned flags;
228-
int ret;
229228

230229
#if HAVE_UCX_DEVICE_MEM
231230
if (hint & SHMEM_HINT_DEVICE_NIC_MEM) {
@@ -337,7 +336,7 @@ static unsigned sshmem_ucx_memheap_ptr2index(map_segment_t *s, void *ptr)
337336
return ((char*)ptr - (char*)s->super.va_base) / ALLOC_ELEM_SIZE;
338337
}
339338

340-
void sshmem_ucx_memheap_wordcopy(void *dst, void *src, size_t size)
339+
static void sshmem_ucx_memheap_wordcopy(void *dst, void *src, size_t size)
341340
{
342341
const size_t count = (size + sizeof(uint64_t) - 1) / sizeof(uint64_t);
343342
uint64_t *dst64 = (uint64_t*)dst;

0 commit comments

Comments
 (0)