Skip to content

Commit d301e68

Browse files
committed
coll_ftagree_earlyreturning.c: temporarily remove dead code
being deleted because, per discussion between @bosilca and @jsquyres on 29 Apr 2021, @bosilca is pretty sure that this code *should* be being invoked from somewhere -- otherwise, we likely have a leak in MPI_FINALIZE. His team is looking into it. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
1 parent 91c4c29 commit d301e68

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

ompi/mca/coll/ftagree/coll_ftagree_earlyreturning.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3332,6 +3332,11 @@ int mca_coll_ftagree_iera_intra(void *contrib,
33323332
return OMPI_SUCCESS;
33333333
}
33343334

3335+
#if 0
3336+
// Per @bosilca and @jsquyres discussion 29 Apr 2021: there is
3337+
// probably a memory leak in MPI_FINALIZE right now, because this
3338+
// function does not appear to be being called from anywhere.
3339+
// @bosilca's team is looking into it.
33353340
int mca_coll_ftagree_era_free_comm(ompi_communicator_t* comm,
33363341
mca_coll_base_module_t *module)
33373342
{
@@ -3369,3 +3374,4 @@ int mca_coll_ftagree_era_free_comm(ompi_communicator_t* comm,
33693374

33703375
return OMPI_SUCCESS;
33713376
}
3377+
#endif

0 commit comments

Comments
 (0)