Skip to content

Commit d1ea105

Browse files
hjelmnawlauria
authored andcommitted
btl/uct: add support for UCX 1.10.x
This commit adjusts for yet another API break in UCT. This time it is the removal of a parameter to a callback function. This change should allow btl/uct to be used with 1.10 so bumping to allow version to reflect the change. Signed-off-by: Nathan Hjelm <hjelmn@google.com> (cherry picked from commit 8fbee98)
1 parent b6dbae2 commit d1ea105

File tree

4 files changed

+32
-4
lines changed

4 files changed

+32
-4
lines changed

opal/mca/btl/uct/btl_uct_endpoint.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,12 +182,22 @@ struct mca_btl_uct_conn_completion_t {
182182
};
183183
typedef struct mca_btl_uct_conn_completion_t mca_btl_uct_conn_completion_t;
184184

185+
#if UCT_API >= ((1L<<UCT_MAJOR_BIT)|(10L << UCT_MINOR_BIT))
186+
static void mca_btl_uct_endpoint_flush_complete(uct_completion_t *self)
187+
{
188+
mca_btl_uct_conn_completion_t *completion = (mca_btl_uct_conn_completion_t *) self;
189+
BTL_VERBOSE(("connection flush complete"));
190+
completion->complete = true;
191+
}
192+
#else
185193
static void mca_btl_uct_endpoint_flush_complete(uct_completion_t *self, ucs_status_t status)
186194
{
187195
mca_btl_uct_conn_completion_t *completion = (mca_btl_uct_conn_completion_t *) self;
196+
(void) status;
188197
BTL_VERBOSE(("connection flush complete"));
189198
completion->complete = true;
190199
}
200+
#endif
191201

192202
static int mca_btl_uct_endpoint_send_conn_req(mca_btl_uct_module_t *uct_btl,
193203
mca_btl_base_endpoint_t *endpoint,

opal/mca/btl/uct/btl_uct_frag.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
#include "btl_uct_frag.h"
1313

14-
static void mca_btl_uct_frag_completion(uct_completion_t *uct_comp, ucs_status_t status)
14+
static void mca_btl_uct_frag_completion_compat(uct_completion_t *uct_comp, ucs_status_t status)
1515
{
1616
mca_btl_uct_uct_completion_t *comp = (mca_btl_uct_uct_completion_t
1717
*) ((uintptr_t) uct_comp
@@ -24,6 +24,16 @@ static void mca_btl_uct_frag_completion(uct_completion_t *uct_comp, ucs_status_t
2424
opal_fifo_push(&comp->dev_context->completion_fifo, &comp->super.super);
2525
}
2626

27+
#if UCT_API >= ((1L<<UCT_MAJOR_BIT)|(10L << UCT_MINOR_BIT))
28+
static void mca_btl_uct_frag_completion(uct_completion_t *uct_comp) {
29+
mca_btl_uct_frag_completion_compat(uct_comp, uct_comp->status);
30+
}
31+
#else
32+
static void mca_btl_uct_frag_completion(uct_completion_t *uct_comp, ucs_status_t status) {
33+
mca_btl_uct_frag_completion_compat(uct_comp, status);
34+
}
35+
#endif
36+
2737
static void mca_btl_uct_base_frag_constructor(mca_btl_uct_base_frag_t *frag)
2838
{
2939
mca_btl_uct_reg_t *reg = (mca_btl_uct_reg_t *) frag->base.super.registration;

opal/mca/btl/uct/btl_uct_rdma.c

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
#include "btl_uct_device_context.h"
1313

14-
void mca_btl_uct_uct_completion(uct_completion_t *uct_comp, ucs_status_t status)
14+
static void mca_btl_uct_uct_completion_compat(uct_completion_t *uct_comp, ucs_status_t status)
1515
{
1616
mca_btl_uct_uct_completion_t *comp = (mca_btl_uct_uct_completion_t
1717
*) ((uintptr_t) uct_comp
@@ -24,6 +24,16 @@ void mca_btl_uct_uct_completion(uct_completion_t *uct_comp, ucs_status_t status)
2424
opal_fifo_push(&comp->dev_context->completion_fifo, &comp->super.super);
2525
}
2626

27+
#if UCT_API >= ((1L<<UCT_MAJOR_BIT)|(10L << UCT_MINOR_BIT))
28+
static void mca_btl_uct_uct_completion(uct_completion_t *uct_comp) {
29+
mca_btl_uct_uct_completion_compat(uct_comp, uct_comp->status);
30+
}
31+
#else
32+
static void mca_btl_uct_uct_completion(uct_completion_t *uct_comp, ucs_status_t status) {
33+
mca_btl_uct_uct_completion_compat(uct_comp, status);
34+
}
35+
#endif
36+
2737
static void mca_btl_uct_uct_completion_construct(mca_btl_uct_uct_completion_t *comp)
2838
{
2939
comp->frag = NULL;

opal/mca/btl/uct/btl_uct_rdma.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ mca_btl_uct_uct_completion_t *mca_btl_uct_uct_completion_alloc(
2828
*/
2929
void mca_btl_uct_uct_completion_release(mca_btl_uct_uct_completion_t *comp);
3030

31-
void mca_btl_uct_uct_completion(uct_completion_t *uct_comp, ucs_status_t status);
32-
3331
/**
3432
* @brief unpack the registration key and ensure the endpoint is connected
3533
*

0 commit comments

Comments
 (0)