Skip to content

Commit cfdb907

Browse files
committed
Debugger stop-in-app flag is boolean
Simplify the defugger flags to avoid confusion and make them all boolean Signed-off-by: Ralph Castain <rhc@pmix.org>
1 parent 32b8a7c commit cfdb907

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

ompi/runtime/ompi_rte.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* and Technology (RIST). All rights reserved.
1515
* Copyright (c) 2020 Amazon.com, Inc. or its affiliates. All Rights
1616
* reserved.
17-
* Copyright (c) 2021 Nanook Consulting. All rights reserved.
17+
* Copyright (c) 2021-2022 Nanook Consulting. All rights reserved.
1818
* Copyright (c) 2021-2022 IBM Corporation. All rights reserved.
1919
* $COPYRIGHT$
2020
*/
@@ -1074,7 +1074,6 @@ void ompi_rte_breakpoint(char *name)
10741074
char *evar;
10751075
int rc, code = PMIX_DEBUGGER_RELEASE;
10761076
pmix_info_t info[2];
1077-
uint32_t u32, *u32ptr;
10781077
opal_process_name_t pname;
10791078

10801079
if (NULL != name
@@ -1085,27 +1084,21 @@ void ompi_rte_breakpoint(char *name)
10851084
}
10861085

10871086
/* check PMIx to see if we are under a debugger */
1088-
u32ptr = &u32;
10891087
pname.jobid = opal_process_info.my_name.jobid;
10901088
pname.vpid = OPAL_VPID_WILDCARD;
10911089
OPAL_MODEX_RECV_VALUE_OPTIONAL(rc, PMIX_DEBUG_STOP_IN_APP,
1092-
&pname, &u32ptr, PMIX_PROC_RANK);
1090+
&pname, NULL, PMIX_BOOL);
10931091
if (PMIX_SUCCESS != rc) {
10941092
/* if not, just return */
10951093
return;
10961094
}
1097-
/* are we included? */
1098-
if (!PMIX_CHECK_RANK(u32, opal_process_info.myprocid.rank)) {
1099-
/* no - ignore it */
1100-
return;
1101-
}
11021095

11031096
/* register an event handler for the PMIX_ERR_DEBUGGER_RELEASE event */
11041097
PMIX_INFO_LOAD(&directive, PMIX_EVENT_HDLR_NAME, "MPI-DEBUGGER-ATTACH", PMIX_STRING);
11051098
PMIx_Register_event_handler(&code, 1, &directive, 1, _release_fn, NULL, NULL);
11061099
PMIX_INFO_DESTRUCT(&directive);
11071100

1108-
/* notify the host that we are waiting */
1101+
/* notify the host that we are waiting in MPI_Init */
11091102
PMIX_INFO_LOAD(&info[0], PMIX_EVENT_NON_DEFAULT, NULL, PMIX_BOOL);
11101103
PMIX_INFO_LOAD(&info[1], PMIX_BREAKPOINT, "mpi-init", PMIX_STRING);
11111104
PMIx_Notify_event(PMIX_READY_FOR_DEBUG,

0 commit comments

Comments
 (0)