Skip to content

Commit c054d4d

Browse files
committed
Ensure we push/pop local AC vars in the right place
Signed-off-by: Ralph Castain <rhc@pmix.org>
1 parent cd1b564 commit c054d4d

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

config/opal_check_pmi.m4

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,7 @@ AC_DEFUN([OPAL_CHECK_PMI],[
243243
# OPAL_CHECK_PMIX_LIB(installdir, libdir, [action-if-valid], [action-if-not-valid])
244244
AC_DEFUN([OPAL_CHECK_PMIX_LIB],[
245245
246+
OPAL_VAR_SCOPE_PUSH([opal_external_pmix_save_CPPFLAGS opal_external_pmix_save_LDFLAGS opal_external_pmix_save_LIBS])
246247
opal_external_pmix_happy=no
247248
248249
# Make sure we have the headers and libs in the correct location
@@ -386,13 +387,13 @@ AC_DEFUN([OPAL_CHECK_PMIX_LIB],[
386387
])
387388
AS_IF([test "$opal_external_pmix_happy" = "yes"],
388389
[$3], [$4])
390+
391+
OPAL_VAR_SCOPE_POP
389392
])
390393

391394

392395
AC_DEFUN([OPAL_CHECK_PMIX],[
393396
394-
OPAL_VAR_SCOPE_PUSH([opal_external_pmix_save_CPPFLAGS opal_external_pmix_save_LDFLAGS opal_external_pmix_save_LIBS])
395-
396397
AC_ARG_WITH([pmix],
397398
[AC_HELP_STRING([--with-pmix(=DIR)],
398399
[Build PMIx support. DIR can take one of three values: "internal", "external", or a valid directory name. "internal" (or no DIR value) forces Open MPI to use its internal copy of PMIx. "external" forces Open MPI to use an external installation of PMIx. Supplying a valid directory name also forces Open MPI to use an external installation of PMIx, and adds DIR/include, DIR/lib, and DIR/lib64 to the search path for headers and libraries. Note that Open MPI does not support --without-pmix.])])
@@ -469,6 +470,4 @@ AC_DEFUN([OPAL_CHECK_PMIX],[
469470
[OPAL_SUMMARY_ADD([[Miscellaneous]],[[PMIx support]], [opal_pmix], [External (1.2.5) WARNING - DYNAMIC OPS NOT SUPPORTED])],
470471
[OPAL_SUMMARY_ADD([[Miscellaneous]],[[PMIx support]], [opal_pmix], [External ($opal_external_pmix_version)])])],
471472
[OPAL_SUMMARY_ADD([[Miscellaneous]], [[PMIx support]], [opal_pmix], [Internal])])
472-
473-
OPAL_VAR_SCOPE_POP
474473
])

0 commit comments

Comments
 (0)