Skip to content

Commit c041042

Browse files
committed
Fix message tags in alltoall/alltoallv
b9012a3 accidently set the message tags for the alltoall and alltoallv in place algorithms to the alltoallw tag. Undo that change. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit f32dc49)
1 parent b58ad5e commit c041042

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

ompi/mca/coll/base/coll_base_alltoall.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
* Copyright (c) 2014-2017 Research Organization for Information Science
1616
* and Technology (RIST). All rights reserved.
1717
* Copyright (c) 2017 IBM Corporation. All rights reserved.
18+
* Copyright (c) 2021 Amazon.com, Inc. or its affiliates. All Rights
19+
* reserved.
1820
* $COPYRIGHT$
1921
*
2022
* Additional copyrights may follow
@@ -108,13 +110,13 @@ mca_coll_base_alltoall_intra_basic_inplace(const void *rbuf, int rcount,
108110

109111
/* Receive data from the right */
110112
err = MCA_PML_CALL(irecv ((char *) rbuf + right * rcount * extent, rcount, rdtype,
111-
right, MCA_COLL_BASE_TAG_ALLTOALLW, comm, &req));
113+
right, MCA_COLL_BASE_TAG_ALLTOALL, comm, &req));
112114
if (MPI_SUCCESS != err) { goto error_hndl; }
113115

114116
if( left != right ) {
115117
/* Send data to the left */
116118
err = MCA_PML_CALL(send ((char *) rbuf + left * rcount * extent, rcount, rdtype,
117-
left, MCA_COLL_BASE_TAG_ALLTOALLW, MCA_PML_BASE_SEND_STANDARD,
119+
left, MCA_COLL_BASE_TAG_ALLTOALL, MCA_PML_BASE_SEND_STANDARD,
118120
comm));
119121
if (MPI_SUCCESS != err) { goto error_hndl; }
120122

@@ -123,13 +125,13 @@ mca_coll_base_alltoall_intra_basic_inplace(const void *rbuf, int rcount,
123125

124126
/* Receive data from the left */
125127
err = MCA_PML_CALL(irecv ((char *) rbuf + left * rcount * extent, rcount, rdtype,
126-
left, MCA_COLL_BASE_TAG_ALLTOALLW, comm, &req));
128+
left, MCA_COLL_BASE_TAG_ALLTOALL, comm, &req));
127129
if (MPI_SUCCESS != err) { goto error_hndl; }
128130
}
129131

130132
/* Send data to the right */
131133
err = MCA_PML_CALL(send ((char *) tmp_buffer, packed_size, MPI_PACKED,
132-
right, MCA_COLL_BASE_TAG_ALLTOALLW, MCA_PML_BASE_SEND_STANDARD,
134+
right, MCA_COLL_BASE_TAG_ALLTOALL, MCA_PML_BASE_SEND_STANDARD,
133135
comm));
134136
if (MPI_SUCCESS != err) { goto error_hndl; }
135137

ompi/mca/coll/base/coll_base_alltoallv.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* Copyright (c) 2014-2017 Research Organization for Information Science
1818
* and Technology (RIST). All rights reserved.
1919
* Copyright (c) 2017 IBM Corporation. All rights reserved.
20+
* Copyright (c) 2021 Amazon.com, Inc. or its affiliates. All Rights
21+
* reserved.
2022
* $COPYRIGHT$
2123
*
2224
* Additional copyrights may follow
@@ -109,14 +111,14 @@ mca_coll_base_alltoallv_intra_basic_inplace(const void *rbuf, const int *rcounts
109111

110112
/* Receive data from the right */
111113
err = MCA_PML_CALL(irecv ((char *) rbuf + rdisps[right], rcounts[right], rdtype,
112-
right, MCA_COLL_BASE_TAG_ALLTOALLW, comm, &req));
114+
right, MCA_COLL_BASE_TAG_ALLTOALLV, comm, &req));
113115
if (MPI_SUCCESS != err) { goto error_hndl; }
114116
}
115117

116118
if( (left != right) && (0 != rcounts[left]) ) {
117119
/* Send data to the left */
118120
err = MCA_PML_CALL(send ((char *) rbuf + rdisps[left], rcounts[left], rdtype,
119-
left, MCA_COLL_BASE_TAG_ALLTOALLW, MCA_PML_BASE_SEND_STANDARD,
121+
left, MCA_COLL_BASE_TAG_ALLTOALLV, MCA_PML_BASE_SEND_STANDARD,
120122
comm));
121123
if (MPI_SUCCESS != err) { goto error_hndl; }
122124

@@ -125,14 +127,14 @@ mca_coll_base_alltoallv_intra_basic_inplace(const void *rbuf, const int *rcounts
125127

126128
/* Receive data from the left */
127129
err = MCA_PML_CALL(irecv ((char *) rbuf + rdisps[left], rcounts[left], rdtype,
128-
left, MCA_COLL_BASE_TAG_ALLTOALLW, comm, &req));
130+
left, MCA_COLL_BASE_TAG_ALLTOALLV, comm, &req));
129131
if (MPI_SUCCESS != err) { goto error_hndl; }
130132
}
131133

132134
if( 0 != rcounts[right] ) { /* nothing to exchange with the peer on the right */
133135
/* Send data to the right */
134136
err = MCA_PML_CALL(send ((char *) tmp_buffer, packed_size, MPI_PACKED,
135-
right, MCA_COLL_BASE_TAG_ALLTOALLW, MCA_PML_BASE_SEND_STANDARD,
137+
right, MCA_COLL_BASE_TAG_ALLTOALLV, MCA_PML_BASE_SEND_STANDARD,
136138
comm));
137139
if (MPI_SUCCESS != err) { goto error_hndl; }
138140

0 commit comments

Comments
 (0)