Merge pull request #6500 from nysal/spinlock_fix

hjelmn · web-flow · commit bf5fb5b58985 · 2019-03-19T07:54:37.000-06:00
opal/atomics: Add acquire semantics back for spinlocks
diff --git a/opal/include/opal/sys/atomic_impl.h b/opal/include/opal/sys/atomic_impl.h
@@ -495,7 +495,7 @@ static inline int
 opal_atomic_trylock(opal_atomic_lock_t *lock)
 {
     int32_t unlocked = OPAL_ATOMIC_LOCK_UNLOCKED;
-    bool ret = opal_atomic_compare_exchange_strong_32 (&lock->u.lock, &unlocked, OPAL_ATOMIC_LOCK_LOCKED);
+    bool ret = opal_atomic_compare_exchange_strong_acq_32 (&lock->u.lock, &unlocked, OPAL_ATOMIC_LOCK_LOCKED);
     return (ret == false) ? 1 : 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -495,7 +495,7 @@ static inline int`
`495`	`495`	`opal_atomic_trylock(opal_atomic_lock_t *lock)`
`496`	`496`	`{`
`497`	`497`	`int32_t unlocked = OPAL_ATOMIC_LOCK_UNLOCKED;`
`498`		`- bool ret = opal_atomic_compare_exchange_strong_32 (&lock->u.lock, &unlocked, OPAL_ATOMIC_LOCK_LOCKED);`
	`498`	`+ bool ret = opal_atomic_compare_exchange_strong_acq_32 (&lock->u.lock, &unlocked, OPAL_ATOMIC_LOCK_LOCKED);`
`499`	`499`	`return (ret == false) ? 1 : 0;`
`500`	`500`	`}`
`501`	`501`