Skip to content

Commit bec7dfc

Browse files
committed
Errors in non-api calls remain fatal
Signed-off-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
1 parent e0df0f4 commit bec7dfc

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

ompi/errhandler/errhandler.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,10 @@ static void *ompi_errhandler_event_cb(int fd, int flags, void *context) {
303303
opal_event_del(&event->super);
304304
free(event);
305305
/* our default action is to abort */
306-
OMPI_ERRHANDLER_NOHANDLE_INVOKE(status, "PMIx Event notification");
306+
/* TODO: this error should return to the caller and invoke an error
307+
* handler from the MPI API call.
308+
* For now, it is fatal. */
309+
ompi_mpi_errors_are_fatal_comm_handler(NULL, status, "PMIx Even Notification");
307310
return NULL;
308311
}
309312

ompi/mca/pml/ob1/pml_ob1.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,10 @@ void mca_pml_ob1_error_handler(
826826
return;
827827
}
828828

829-
ompi_rte_abort(-1, btlinfo);
829+
/* TODO: this error should return to the caller and invoke an error
830+
* handler from the MPI API call.
831+
* For now, it is fatal. */
832+
ompi_mpi_errors_are_fatal_comm_handler(NULL, -1, btlinfo);
830833
}
831834

832835
#if OPAL_ENABLE_FT_CR == 0

0 commit comments

Comments
 (0)