Skip to content

Commit bb40829

Browse files
cchambreaukingshuk00
authored andcommitted
Ensure consistency between ompi and opal callback safety requirement
values. Signed-off-by: Chris Chambreau <chambreau1@llnl.gov>
1 parent 00536b5 commit bb40829

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

ompi/include/mpi.h.in

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -917,12 +917,18 @@ enum {
917917

918918
/*
919919
* MPIT callback safety levels
920+
*
921+
* Values are set in configure.ac for consistency with mca_base_event.h
920922
*/
923+
#undef OPAL_MCA_BASE_CB_REQUIRE_NONE
924+
#undef OPAL_MCA_BASE_CB_REQUIRE_MPI_RESTRICTED
925+
#undef OPAL_MCA_BASE_CB_REQUIRE_THREAD_SAFE
926+
#undef OPAL_MCA_BASE_CB_REQUIRE_ASYNC_SIGNAL_SAFE
921927
typedef enum {
922-
MPI_T_CB_REQUIRE_NONE,
923-
MPI_T_CB_REQUIRE_MPI_RESTRICTED,
924-
MPI_T_CB_REQUIRE_THREAD_SAFE,
925-
MPI_T_CB_REQUIRE_ASYNC_SIGNAL_SAFE
928+
MPI_T_CB_REQUIRE_NONE = OPAL_MCA_BASE_CB_REQUIRE_NONE,
929+
MPI_T_CB_REQUIRE_MPI_RESTRICTED = OPAL_MCA_BASE_CB_REQUIRE_MPI_RESTRICTED,
930+
MPI_T_CB_REQUIRE_THREAD_SAFE = OPAL_MCA_BASE_CB_REQUIRE_THREAD_SAFE,
931+
MPI_T_CB_REQUIRE_ASYNC_SIGNAL_SAFE = OPAL_MCA_BASE_CB_REQUIRE_ASYNC_SIGNAL_SAFE
926932
} MPI_T_cb_safety;
927933

928934
/*

opal/mca/base/mca_base_event.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ typedef enum {
4242
/**
4343
* @basic Callback safety levels
4444
*
45-
* If these are modified then similar modifications will be needed in mpi.h.in.
45+
* Values are set in configure.ac for consistency with mpi.h
4646
*/
4747
typedef enum {
48-
MCA_BASE_CB_REQUIRE_NONE,
49-
MCA_BASE_CB_REQUIRE_MPI_RESTRICTED,
50-
MCA_BASE_CB_REQUIRE_THREAD_SAFE,
51-
MCA_BASE_CB_REQUIRE_ASYNC_SIGNAL_SAFE,
48+
MCA_BASE_CB_REQUIRE_NONE = OPAL_MCA_BASE_CB_REQUIRE_NONE,
49+
MCA_BASE_CB_REQUIRE_MPI_RESTRICTED = OPAL_MCA_BASE_CB_REQUIRE_MPI_RESTRICTED,
50+
MCA_BASE_CB_REQUIRE_THREAD_SAFE = OPAL_MCA_BASE_CB_REQUIRE_THREAD_SAFE,
51+
MCA_BASE_CB_REQUIRE_ASYNC_SIGNAL_SAFE = OPAL_MCA_BASE_CB_REQUIRE_ASYNC_SIGNAL_SAFE,
5252
MCA_BASE_CB_SAFETY_MAX,
5353
} mca_base_cb_safety_t;
5454

0 commit comments

Comments
 (0)